Falkon/falkonOfficial
Falkon/falkonOfficial
1
Fork 0
mirror of https://invent.kde.org/network/falkon.git synced 2024-12-20 10:46:35 +01:00
Code Releases Activity

All issues regarding saving passwords should now be fixed.

Browse Source 
closes #413
This commit is contained in:
nowrep 2012-07-10 22:15:07 +02:00
parent 2d5c9bcc2b
commit 11972affaf
3 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BUILDING
View File

@ -161,7 +161,7 @@ Available Defines
example: example:
$ export QUPZILLA_PREFIX="/usr/" $ export QUPZILLA_PREFIX="/usr/"
DISABLE_DBUS Build without QtDBUS module. Native desktop notifications will be disabled. DISABLE_DBUS Build without QtDBus module. Native desktop notifications will be disabled.
example: example:
$ export DISABLE_DBUS="true" $ export DISABLE_DBUS="true"

1
CHANGELOG
View File

@ -24,6 +24,7 @@ Version 1.3.0
* Linux: middle clicking on add tab button will open new tab with global mouse selection's contents * Linux: middle clicking on add tab button will open new tab with global mouse selection's contents
* Linux: generating backtrace and saving it into file upon application crash * Linux: generating backtrace and saving it into file upon application crash
* Windows: fixed theme loading delay (showing ugly interface for a second when starting app) * Windows: fixed theme loading delay (showing ugly interface for a second when starting app)
* fixed all issues with saving password (i hope so)
* fixed saving passwords on some sites (parsing WebKit's data format) * fixed saving passwords on some sites (parsing WebKit's data format)
* fixed "go to web address" action when newlines were in string * fixed "go to web address" action when newlines were in string
* fixed excessive ssl warnings when rejecting untrusted certificate * fixed excessive ssl warnings when rejecting untrusted certificate

16
src/lib/autofill/autofillmodel.cpp
View File

@ -233,7 +233,7 @@ void AutoFillModel::completePage(WebPage* page)
void AutoFillModel::post(const QNetworkRequest &request, const QByteArray &outgoingData) void AutoFillModel::post(const QNetworkRequest &request, const QByteArray &outgoingData)
{ {
//Dont save in private browsing // Don't save in private browsing
if (mApp->isPrivateSession()) { if (mApp->isPrivateSession()) {
return; return;
} }
@ -250,18 +250,19 @@ void AutoFillModel::post(const QNetworkRequest &request, const QByteArray &outgo
return; return;
} }
v = request.attribute((QNetworkRequest::Attribute)(QNetworkRequest::User + 101)); // v = request.attribute((QNetworkRequest::Attribute)(QNetworkRequest::User + 101));
QWebPage::NavigationType type = (QWebPage::NavigationType)v.toInt(); // QWebPage::NavigationType type = (QWebPage::NavigationType)v.toInt();
if (type != QWebPage::NavigationTypeFormSubmitted) { // if (type != QWebPage::NavigationTypeFormSubmitted) {
return; // return;
} // }
QString usernameName; QString usernameName;
QString usernameValue; QString usernameValue;
QString passwordName; QString passwordName;
QString passwordValue; QString passwordValue;
QUrl siteUrl = webPage->url();
const QUrl &siteUrl = webPage->url();
if (!isStoringEnabled(siteUrl)) { if (!isStoringEnabled(siteUrl)) {
return; return;
@ -305,6 +306,7 @@ void AutoFillModel::post(const QNetworkRequest &request, const QByteArray &outgo
foreach(const QWebElement & element, foundForm.findAll("input[type=\"text\"]")) { foreach(const QWebElement & element, foundForm.findAll("input[type=\"text\"]")) {
usernameName = element.attribute("name"); usernameName = element.attribute("name");
usernameValue = getValueFromData(data, element); usernameValue = getValueFromData(data, element);
if (!usernameName.isEmpty() && !usernameValue.isEmpty()) { if (!usernameName.isEmpty() && !usernameValue.isEmpty()) {
break; break;
} }