From 159a0c97d357d05bf1ec7029ec4d7f108fa3602e Mon Sep 17 00:00:00 2001 From: nowrep Date: Sun, 12 Feb 2012 18:02:05 +0100 Subject: [PATCH] [Fix] Fixed potential endless loop when getting error opening url. - when there is navigating error to http(s) page and WebKit throw unsupported content error, there is possibility to stuck in endless new tab opening loop when user has QupZilla as provider for http(s) scheme --- src/webview/webpage.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/webview/webpage.cpp b/src/webview/webpage.cpp index ac637afa3..c26ca5243 100644 --- a/src/webview/webpage.cpp +++ b/src/webview/webpage.cpp @@ -223,7 +223,13 @@ void WebPage::handleUnsupportedContent(QNetworkReply* reply) case QNetworkReply::ProtocolUnknownError: qDebug() << "WebPage::UnsupportedContent" << url << "ProtocolUnknowError"; - QDesktopServices::openUrl(url); + + // We are not going to end in endless new tab opening loop in case + // user has QupZilla as default provider for http / https urls + if (!url.scheme().startsWith("http")) { + QDesktopServices::openUrl(url); + } + reply->deleteLater(); return;