From 2582ee35620bdd60949ea07bb6449c4127d2220c Mon Sep 17 00:00:00 2001
From: David Rosca <nowrep@gmail.com>
Date: Tue, 29 Sep 2015 11:21:17 +0200
Subject: [PATCH] Update expectations for popupwindows test

---
 src/lib/webengine/webpage.cpp | 4 +++-
 tests/popupwindows.html       | 4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/lib/webengine/webpage.cpp b/src/lib/webengine/webpage.cpp
index ee54dcec2..d982e9c0f 100644
--- a/src/lib/webengine/webpage.cpp
+++ b/src/lib/webengine/webpage.cpp
@@ -964,7 +964,9 @@ QWebEnginePage* WebPage::createWindow(QWebEnginePage::WebWindowType type)
     BrowserWindow *window = tView ? tView->browserWindow() : mApp->getWindow();
 
     switch (type) {
-    case QWebEnginePage::WebBrowserWindow: // TODO
+    case QWebEnginePage::WebBrowserWindow:
+        // TODO: Investigate when this is called from html
+        qDebug() << "WebBrowserWindow";
     case QWebEnginePage::WebBrowserTab: {
         int index = window->tabWidget()->addView(QUrl(), Qz::NT_CleanSelectedTab);
         TabbedWebView* view = window->weView(index);
diff --git a/tests/popupwindows.html b/tests/popupwindows.html
index 01384921a..33daed079 100644
--- a/tests/popupwindows.html
+++ b/tests/popupwindows.html
@@ -18,11 +18,11 @@
 <a href="javascript:window.open('popup.html', '_blank')">Popup 2</a>
 - with second argument _blank
 </p>
+<b>Will be opened in popup window</b>
 <p>
 <a href="javascript:window.open('popup.html', '_blank', 'left=100,right=200')">Popup 3</a>
-- with left and righ (should be opened as popup, but how to detect it?)
+- with left and righ
 </p>
-<b>Will be opened in popup window</b>
 <p>
 <a href="javascript:window.open('popup.html', '_blank', 'width=150,height=150')">Popup 4</a>
 - with width and height