Falkon/falkonOfficial
Falkon/falkonOfficial
1
Fork 0
mirror of https://invent.kde.org/network/falkon.git synced 2024-12-20 02:36:34 +01:00
Code Releases Activity

[Regression] Fixed handling key press events in webview.

Browse Source 
Regression from 7c9b30c443
This commit is contained in:
nowrep 2013-04-15 23:21:00 +02:00
parent 4a72f493bf
commit 373050bef0
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/lib/webview/webview.cpp
View File

@ -1231,13 +1231,19 @@ void WebView::keyPressEvent(QKeyEvent* event)
int eventKey = event->key();
bool rightOrLeft = eventKey == Qt::Key_Left || eventKey == Qt::Key_Right;
if (rightOrLeft) {
// The right/left arrow keys within contents with right to left (RTL) layout have
// reversed behavior than left to right (LTR) layout.
// Example: Key_Right within LTR layout triggers QWebPage::MoveToNextChar but,
// Key_Right within RTL layout should trigger QWebPage::MoveToPreviousChar
if (eventKey == Qt::Key_Left || eventKey == Qt::Key_Right) {
const QWebElement &elementHasCursor = activeElement();
if (!elementHasCursor.isNull()) {
bool isRTL = elementHasCursor.styleProperty("direction", QWebElement::ComputedStyle) == QLatin1String("rtl");
if (isRTL) {
const QString &direction = elementHasCursor.styleProperty("direction", QWebElement::ComputedStyle);
if (direction == QLatin1String("rtl")) {
eventKey = eventKey == Qt::Key_Left ? Qt::Key_Right : Qt::Key_Left;
QKeyEvent ev(event->type(), eventKey, event->modifiers(), event->text(), event->isAutoRepeat());
event = &ev;
}
}
}
@ -1331,8 +1337,6 @@ void WebView::keyPressEvent(QKeyEvent* event)
break;
}
event = new QKeyEvent(event->type(), eventKey, event->modifiers(),
event->text(), event->isAutoRepeat());
QWebView::keyPressEvent(event);
}