Falkon/falkonOfficial
Falkon/falkonOfficial
1
Fork 0
mirror of https://invent.kde.org/network/falkon.git synced 2024-12-20 10:46:35 +01:00
Code Releases Activity

[AKN] Fixes crash while closing tab with shown labels.

Browse Source 
See #817
This commit is contained in:
nowrep 2013-03-21 15:13:08 +01:00
parent cec51fc0d5
commit 39af453281
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/AccessKeysNavigation/akn_handler.cpp
View File

@ -320,6 +320,13 @@ void AKN_Handler::showAccessKeys()
void AKN_Handler::hideAccessKeys() void AKN_Handler::hideAccessKeys()
{ {
if (!m_accessKeyLabels.isEmpty() && m_view) { if (!m_accessKeyLabels.isEmpty() && m_view) {
// Fixes crash when hiding labels while closing view
if (!m_view->inherits("WebView")) {
m_accessKeyLabels.clear();
m_accessKeyNodes.clear();
return;
}
for (int i = 0; i < m_accessKeyLabels.count(); ++i) { for (int i = 0; i < m_accessKeyLabels.count(); ++i) {
QLabel* label = m_accessKeyLabels[i]; QLabel* label = m_accessKeyLabels[i];
label->hide(); label->hide();

2
src/plugins/AccessKeysNavigation/akn_plugin.cpp
View File

@ -36,7 +36,7 @@ PluginSpec AKN_Plugin::pluginSpec()
spec.name = "Access Keys Navigation"; spec.name = "Access Keys Navigation";
spec.info = "Access keys navigation for QupZilla"; spec.info = "Access keys navigation for QupZilla";
spec.description = "Provides support for navigating in webpages by keyboard shortcuts"; spec.description = "Provides support for navigating in webpages by keyboard shortcuts";
spec.version = "0.4.2"; spec.version = "0.4.3";
spec.author = "David Rosca <nowrep@gmail.com>"; spec.author = "David Rosca <nowrep@gmail.com>";
spec.icon = QPixmap(":/accesskeysnavigation/data/icon.png"); spec.icon = QPixmap(":/accesskeysnavigation/data/icon.png");
spec.hasSettings = true; spec.hasSettings = true;