Falkon/falkonOfficial
Falkon/falkonOfficial
1
Fork 0
mirror of https://invent.kde.org/network/falkon.git synced 2024-11-11 09:32:12 +01:00
Code Releases Activity

Added tests for browsingWindow in Qml Tabs API

Browse Source
This commit is contained in:
Anmol Gautam 2018-06-05 14:30:27 +05:30
parent 98e24221bf
commit 4ff62c3d0a
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
autotests/qml/qmltabsapitest.cpp
View File

@ -84,8 +84,6 @@ void QmlTabsApiTest::testTabsAPI()
QCOMPARE(qmlTabObject3->property("index").toInt(), 0); QCOMPARE(qmlTabObject3->property("index").toInt(), 0);
QCOMPARE(qmlTabObject3->property("pinned").toBool(), false); QCOMPARE(qmlTabObject3->property("pinned").toBool(), false);
// TODO: when the windowId is different from current window
// Next-Previous-Current // Next-Previous-Current
QCOMPARE(mApp->getWindow()->tabWidget()->currentIndex(), 0); QCOMPARE(mApp->getWindow()->tabWidget()->currentIndex(), 0);
qmlTest.evaluate("Falkon.Tabs.nextTab()"); qmlTest.evaluate("Falkon.Tabs.nextTab()");
@ -103,7 +101,7 @@ void QmlTabsApiTest::testTabsAPI()
// Move Tab // Move Tab
QSignalSpy qmlTabsMovedSpy(qmlTabsObject, SIGNAL(tabMoved(QVariantMap))); QSignalSpy qmlTabsMovedSpy(qmlTabsObject, SIGNAL(tabMoved(QVariantMap)));
qmlTest.evaluate("Falkon.Tabs.moveTab({from: 0, to:1})"); qmlTest.evaluate("Falkon.Tabs.moveTab({from: 0, to:1, windowId: 0})");
QCOMPARE(qmlTabsMovedSpy.count(), 1); QCOMPARE(qmlTabsMovedSpy.count(), 1);
// Tab Removal // Tab Removal
@ -112,6 +110,20 @@ void QmlTabsApiTest::testTabsAPI()
qmlTest.evaluate("Falkon.Tabs.closeTab({index: 0})"); qmlTest.evaluate("Falkon.Tabs.closeTab({index: 0})");
QCOMPARE(qmlTabsRemovedSpy.count(), 1); QCOMPARE(qmlTabsRemovedSpy.count(), 1);
QCOMPARE(mApp->getWindow()->tabCount(), 1); QCOMPARE(mApp->getWindow()->tabCount(), 1);
// windowId is different from current window
BrowserWindow *otherWindow = mApp->createWindow(Qz::BW_NewWindow);
QCOMPARE(otherWindow->tabCount(), 0);
qmlTest.evaluate("Falkon.Tabs.addTab({"
" url: 'https://example.com/',"
" windowId: 1"
"})");
QCOMPARE(otherWindow->tabCount(), 1);
QObject *otherWindowTab = qmlTest.evaluateQObject("Falkon.Tabs.get({index: 0, windowId: 1})");
QVERIFY(otherWindowTab);
QObject *windowOfOtherWindowTab = qvariant_cast<QObject*>(otherWindowTab->property("browserWindow"));
QVERIFY(windowOfOtherWindowTab);
QCOMPARE(windowOfOtherWindowTab->property("id").toInt(), mApp->windowIdHash().value(otherWindow));
} }
FALKONTEST_MAIN(QmlTabsApiTest) FALKONTEST_MAIN(QmlTabsApiTest)