From 6780335dc988f4165adece89fb2917ec6ed9066e Mon Sep 17 00:00:00 2001
From: David Rosca
Date: Wed, 21 Oct 2015 20:55:12 +0200
Subject: [PATCH] Drop showing build time in version info
Build time was a nice idea, but it only saved build time for
qzcommon.cpp (which was builded only with clean build) and it
also breaks reproducible builds.
A variation of this patch is already used by some distros.
---
src/lib/app/qzcommon.cpp | 1 -
src/lib/app/qzcommon.h | 1 -
src/lib/network/schemehandlers/qupzillaschemehandler.cpp | 1 -
src/lib/other/aboutdialog.cpp | 1 -
4 files changed, 4 deletions(-)
diff --git a/src/lib/app/qzcommon.cpp b/src/lib/app/qzcommon.cpp
index ff892ce12..9e594de21 100644
--- a/src/lib/app/qzcommon.cpp
+++ b/src/lib/app/qzcommon.cpp
@@ -25,7 +25,6 @@ const int bookmarksVersion = 1;
QUPZILLA_EXPORT const char* APPNAME = "QupZilla";
QUPZILLA_EXPORT const char* VERSION = QUPZILLA_VERSION;
-QUPZILLA_EXPORT const char* BUILDTIME = __DATE__ " " __TIME__;
QUPZILLA_EXPORT const char* AUTHOR = "David Rosca";
QUPZILLA_EXPORT const char* COPYRIGHT = "2010-2015";
QUPZILLA_EXPORT const char* WWWADDRESS = "http://www.qupzilla.com";
diff --git a/src/lib/app/qzcommon.h b/src/lib/app/qzcommon.h
index 62f19145d..8045001d3 100644
--- a/src/lib/app/qzcommon.h
+++ b/src/lib/app/qzcommon.h
@@ -60,7 +60,6 @@ extern const int bookmarksVersion;
QUPZILLA_EXPORT extern const char* APPNAME;
QUPZILLA_EXPORT extern const char* VERSION;
-QUPZILLA_EXPORT extern const char* BUILDTIME;
QUPZILLA_EXPORT extern const char* AUTHOR;
QUPZILLA_EXPORT extern const char* COPYRIGHT;
QUPZILLA_EXPORT extern const char* WWWADDRESS;
diff --git a/src/lib/network/schemehandlers/qupzillaschemehandler.cpp b/src/lib/network/schemehandlers/qupzillaschemehandler.cpp
index 15e4a933e..a7dcc7b68 100644
--- a/src/lib/network/schemehandlers/qupzillaschemehandler.cpp
+++ b/src/lib/network/schemehandlers/qupzillaschemehandler.cpp
@@ -382,7 +382,6 @@ QString QupZillaSchemeReply::configPage()
#endif
) +
QString("%1%2").arg(tr("Qt version"), QT_VERSION_STR) +
- QString("%1%2").arg(tr("Build time"), Qz::BUILDTIME) +
QString("%1%2").arg(tr("Platform"), QzTools::operatingSystem()));
cPage.replace(QLatin1String("%PATHS-TEXT%"),
diff --git a/src/lib/other/aboutdialog.cpp b/src/lib/other/aboutdialog.cpp
index a88e4b3b6..79f3c04f2 100644
--- a/src/lib/other/aboutdialog.cpp
+++ b/src/lib/other/aboutdialog.cpp
@@ -75,7 +75,6 @@ void AboutDialog::showAbout()
);
m_aboutHtml += tr("QtWebEngine version %1
").arg(QT_VERSION_STR);
m_aboutHtml += QString("© %1 %2
").arg(Qz::COPYRIGHT, Qz::AUTHOR);
- m_aboutHtml += tr("Build time: %1
").arg(Qz::BUILDTIME);
m_aboutHtml += QString("%1
").arg(Qz::WWWADDRESS);
m_aboutHtml += "" + mApp->userAgentManager()->defaultUserAgent() + "
";
m_aboutHtml += "";