From a154ef54806cf4a4989d069502fec4100c8e09ca Mon Sep 17 00:00:00 2001 From: Anmol Gautam Date: Wed, 6 Mar 2019 17:53:41 +0530 Subject: [PATCH] fix context menu on falkon:speeddial Summary: Function addSpeedDial and others are not in scope so they didn't worked when called via javascript. So, I have removed the anonymous function which is wrapping those functions. Reviewers: drosca Reviewed By: drosca Subscribers: falkon Tags: #falkon Differential Revision: https://phabricator.kde.org/D19564 --- src/lib/data/html/speeddial.user.js | 4 ---- src/lib/webengine/webview.cpp | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/lib/data/html/speeddial.user.js b/src/lib/data/html/speeddial.user.js index b59ac8723..bd50affa5 100644 --- a/src/lib/data/html/speeddial.user.js +++ b/src/lib/data/html/speeddial.user.js @@ -4,8 +4,6 @@ // @include falkon:speeddial // ==/UserScript== -(function() { - var scriptData = {}; var editingId = -1; var ignoreNextChanged = false; @@ -498,5 +496,3 @@ if (window._falkon_external) { } else { document.addEventListener("_falkon_external_created", init); } - -})(); diff --git a/src/lib/webengine/webview.cpp b/src/lib/webengine/webview.cpp index 306fdff8c..0a736bf4b 100644 --- a/src/lib/webengine/webview.cpp +++ b/src/lib/webengine/webview.cpp @@ -945,17 +945,17 @@ void WebView::createSearchEngine() void WebView::addSpeedDial() { - page()->runJavaScript("addSpeedDial()"); + page()->runJavaScript("addSpeedDial()", WebPage::SafeJsWorld); } void WebView::configureSpeedDial() { - page()->runJavaScript("configureSpeedDial()"); + page()->runJavaScript("configureSpeedDial()", WebPage::SafeJsWorld); } void WebView::reloadAllSpeedDials() { - page()->runJavaScript("reloadAll()"); + page()->runJavaScript("reloadAll()", WebPage::SafeJsWorld); } void WebView::toggleMediaPause()