From c36e59c31e2e44f2a2bb70848dfe07f6654b03c7 Mon Sep 17 00:00:00 2001 From: Franz Fellner Date: Sun, 9 Dec 2012 08:15:21 +0100 Subject: [PATCH] Set m_ignoreCurrentChangedSignal to false directly after setCurrentIndex() instead of in currentChanged(). This solves problems for the very first popup not triggering currentChanged(), so in that case the first item did not set the completion url. As long as the connection type to currentChanged() remains a DirectConnection, this fix should work. --- src/lib/navigation/completer/locationcompleter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/navigation/completer/locationcompleter.cpp b/src/lib/navigation/completer/locationcompleter.cpp index bbf74cfe2..d7849e422 100644 --- a/src/lib/navigation/completer/locationcompleter.cpp +++ b/src/lib/navigation/completer/locationcompleter.cpp @@ -65,7 +65,6 @@ void LocationCompleter::showMostVisited() void LocationCompleter::currentChanged(const QModelIndex &index) { if (m_ignoreCurrentChangedSignal) { - m_ignoreCurrentChangedSignal = false; return; } @@ -124,6 +123,7 @@ void LocationCompleter::adjustPopupSize() s_view->resize(s_view->width(), popupHeight); m_ignoreCurrentChangedSignal = true; s_view->setCurrentIndex(QModelIndex()); + m_ignoreCurrentChangedSignal = false; s_view->show(); m_originalText = m_locationBar->text();