diff --git a/src/lib/bookmarks/bookmarkicon.cpp b/src/lib/bookmarks/bookmarkicon.cpp index 0ec9231ec..af13f6c74 100644 --- a/src/lib/bookmarks/bookmarkicon.cpp +++ b/src/lib/bookmarks/bookmarkicon.cpp @@ -47,7 +47,7 @@ BookmarkIcon::BookmarkIcon(QupZilla* mainClass, QWidget* parent) void BookmarkIcon::iconClicked() { - BookmarksWidget* menu = new BookmarksWidget(p_QupZilla->weView(), p_QupZilla->locationBar()); + BookmarksWidget* menu = new BookmarksWidget(p_QupZilla, p_QupZilla->weView(), p_QupZilla->locationBar()); menu->showAt(this); } diff --git a/src/lib/bookmarks/bookmarkswidget.cpp b/src/lib/bookmarks/bookmarkswidget.cpp index d8b2647ea..223f3cf2f 100644 --- a/src/lib/bookmarks/bookmarkswidget.cpp +++ b/src/lib/bookmarks/bookmarkswidget.cpp @@ -22,13 +22,15 @@ #include "pluginproxy.h" #include "speeddial.h" #include "webview.h" +#include "qupzilla.h" #include #include -BookmarksWidget::BookmarksWidget(WebView* view, QWidget* parent) +BookmarksWidget::BookmarksWidget(QupZilla *mainClass, WebView* view, QWidget* parent) : QMenu(parent) , ui(new Ui::BookmarksWidget) + , p_QupZilla(mainClass) , m_url(view->url()) , m_view(view) , m_bookmarksModel(mApp->bookmarksModel()) @@ -36,17 +38,18 @@ BookmarksWidget::BookmarksWidget(WebView* view, QWidget* parent) { ui->setupUi(this); setAttribute(Qt::WA_DeleteOnClose); + + // The locationbar's direction is direction of its text, + // it dynamically changes and so, it's not good choice for this widget. + setLayoutDirection(QApplication::layoutDirection()); + connect(ui->close, SIGNAL(clicked()), this, SLOT(close())); connect(ui->removeBookmark, SIGNAL(clicked()), this, SLOT(removeBookmark())); connect(ui->save, SIGNAL(clicked()), this, SLOT(saveBookmark())); - connect(ui->bookmarksButton, SIGNAL(clicked()), this, SLOT(addBookmark())); + connect(ui->organizeBookmarksButton, SIGNAL(clicked()), p_QupZilla, SLOT(showBookmarksManager())); connect(ui->speeddialButton, SIGNAL(clicked()), this, SLOT(toggleSpeedDial())); - if (m_bookmarksModel->isBookmarked(m_url)) { - ui->bookmarksButton->setText(tr("Edit Bookmark")); - } - const SpeedDial::Page &page = m_speedDial->pageForUrl(m_url); ui->speeddialButton->setText(page.url.isEmpty() ? tr("Add to Speed Dial") : tr("Remove from Speed Dial")); @@ -57,13 +60,13 @@ BookmarksWidget::BookmarksWidget(WebView* view, QWidget* parent) ui->label_2->setPalette(pal); ui->label_3->setPalette(pal); #endif + + addBookmark(); } void BookmarksWidget::loadBookmark() { if (m_bookmarksModel->isBookmarked(m_url)) { - ui->stackedWidget->setCurrentIndex(0); - m_bookmarkId = m_bookmarksModel->bookmarkId(m_url); BookmarksModel::Bookmark bookmark = m_bookmarksModel->getBookmark(m_bookmarkId); ui->name->setText(bookmark.title); diff --git a/src/lib/bookmarks/bookmarkswidget.h b/src/lib/bookmarks/bookmarkswidget.h index e99abf6d3..f643548f3 100644 --- a/src/lib/bookmarks/bookmarkswidget.h +++ b/src/lib/bookmarks/bookmarkswidget.h @@ -31,11 +31,13 @@ class BookmarksWidget; class WebView; class SpeedDial; class BookmarksModel; +class QupZilla; + class QT_QUPZILLA_EXPORT BookmarksWidget : public QMenu { Q_OBJECT public: - explicit BookmarksWidget(WebView* view, QWidget* parent = 0); + explicit BookmarksWidget(QupZilla* mainClass, WebView* view, QWidget* parent = 0); ~BookmarksWidget(); void showAt(QWidget* _parent); @@ -57,6 +59,7 @@ private: Ui::BookmarksWidget* ui; QUrl m_url; int m_bookmarkId; + QupZilla* p_QupZilla; WebView* m_view; BookmarksModel* m_bookmarksModel; diff --git a/src/lib/bookmarks/bookmarkswidget.ui b/src/lib/bookmarks/bookmarkswidget.ui index d15189ca5..66cc8fa66 100644 --- a/src/lib/bookmarks/bookmarkswidget.ui +++ b/src/lib/bookmarks/bookmarkswidget.ui @@ -7,169 +7,139 @@ 0 0 275 - 98 + 130 - - - 0 - 0 - - - + - - - 0 - + - - - QFrame::NoFrame + + + + + + 0 + 0 + + + + Add to Speed Dial + + + + + + + + 0 + 0 + + + + Organize Bookmarks + + + + + + + + + + + Name: + + + + + + + + + + + + + + Folder: + + + + + + + + 0 + 0 + + + + + + + + + + 5 - - - 9 - - - - - 1 - - - - - 0 - - - - - Folder: - - - - - - - Name: - - - - - - - - - - - - - 5 - - - - - - 0 - 0 - - - - Remove - - - - - - - Qt::Horizontal - - - - 40 - 20 - - - - - - - - - 0 - 0 - - - - Save - - - - - - - - 0 - 0 - - - - Close - - - - - - - - - - - 25 - - - 0 - - - 25 - - - 0 - - - - - Add to Bookmarks - - - - - - - Add to Speed Dial - - - - - - - - - + + + + + 0 + 0 + + + + Remove + + + + + + + Qt::Horizontal + + + + 40 + 20 + + + + + + + + + 0 + 0 + + + + Save + + + + + + + + 0 + 0 + + + + Close + + + + - - - Frame - QFrame -
frame.h
- 1 -
-
- - - +