Falkon/falkonOfficial
Falkon/falkonOfficial
1
Fork 0
mirror of https://invent.kde.org/network/falkon.git synced 2024-11-13 10:32:11 +01:00
Code Releases Activity

[PACTest] Correctly accept localhost resolved IPv4/6 addresses

Browse Source
This commit is contained in:
nowrep 2014-02-01 17:55:20 +01:00
parent 3635edc88f
commit d65512d9f6
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/autotests/pactest.cpp
View File

@ -159,7 +159,7 @@ void PacTest::dnsResolveTest_data()
QTest::addColumn<QString>("host"); QTest::addColumn<QString>("host");
QTest::addColumn<QString>("result"); QTest::addColumn<QString>("result");
QTest::newRow("localhost") << "localhost" << "127.0.0.1"; QTest::newRow("localhost") << "localhost" << "";
QTest::newRow("qz") << "qupzilla.com" << "85.118.128.38"; // This may change... QTest::newRow("qz") << "qupzilla.com" << "85.118.128.38"; // This may change...
} }
@ -169,7 +169,16 @@ void PacTest::dnsResolveTest()
QFETCH(QString, result); QFETCH(QString, result);
QString source = QString("dnsResolve('%1')").arg(host); QString source = QString("dnsResolve('%1')").arg(host);
QCOMPARE(m_runner->evaluate(source).toString(), result); QString res = m_runner->evaluate(source).toString();
if (host == "localhost") {
if (res != "127.0.0.1" && res != "::1") {
QFAIL("localhost incorrectly resolved!");
}
return;
}
QCOMPARE(res, result);
} }
void PacTest::dnsDomainLevelsTest_data() void PacTest::dnsDomainLevelsTest_data()