From e02a8ee6645f18a91340d8dac7bcf9152a9ab051 Mon Sep 17 00:00:00 2001 From: Juraj Oravec Date: Fri, 17 Nov 2023 20:58:45 +0100 Subject: [PATCH] Remove Qt5 support --- CMakeLists.txt | 66 ++++++------------- src/lib/3rdparty/fancytabwidget.cpp | 4 -- src/lib/3rdparty/fancytabwidget.h | 4 -- .../qtsingleapplication/qtlocalpeer.cpp | 7 -- src/lib/3rdparty/stylehelper.cpp | 8 --- src/lib/CMakeLists.txt | 49 ++++---------- src/lib/adblock/adblockmanager.cpp | 4 -- src/lib/adblock/adblockrule.cpp | 7 +- src/lib/adblock/adblocksubscription.cpp | 14 +--- src/lib/app/browserwindow.cpp | 14 ---- src/lib/app/mainapplication.cpp | 25 ------- src/lib/app/mainapplication.h | 8 --- src/lib/autofill/autofill.cpp | 3 - .../bookmarksexport/htmlexporter.cpp | 6 +- .../bookmarksimport/operaimporter.cpp | 6 +- src/lib/bookmarks/bookmarkstoolbarbutton.cpp | 4 -- src/lib/bookmarks/bookmarkstoolbarbutton.h | 4 -- src/lib/downloads/downloaditem.cpp | 22 ++----- src/lib/downloads/downloaditem.h | 14 +--- src/lib/downloads/downloadmanager.cpp | 32 +++------ src/lib/downloads/downloadmanager.h | 12 ---- src/lib/downloads/downloadmanagermodel.cpp | 4 -- src/lib/downloads/downloadoptionsdialog.cpp | 6 +- src/lib/downloads/downloadoptionsdialog.h | 8 +-- .../completer/locationcompleterdelegate.cpp | 4 -- .../completer/locationcompleterrefreshjob.cpp | 4 -- src/lib/navigation/websearchbar.cpp | 4 -- src/lib/network/networkmanager.cpp | 21 +----- src/lib/network/networkmanager.h | 9 --- src/lib/opensearch/editsearchengine.cpp | 4 -- src/lib/opensearch/searchenginesdialog.cpp | 4 -- src/lib/plugins/ocssupport.cpp | 4 -- .../qml/api/userscript/qmluserscript.cpp | 6 -- .../qml/api/userscript/qmluserscript.h | 6 +- .../qml/api/userscript/qmluserscripts.cpp | 9 --- src/lib/preferences/autofillmanager.cpp | 8 --- src/lib/preferences/preferences.cpp | 7 -- src/lib/tabwidget/combotabbar.cpp | 7 -- src/lib/tabwidget/combotabbar.h | 4 -- src/lib/tools/buttonwithmenu.cpp | 4 -- src/lib/tools/desktopfile.cpp | 3 - .../html5permissionsnotification.cpp | 4 -- src/lib/tools/pagethumbnailer.cpp | 4 -- src/lib/tools/qztools.cpp | 15 ----- src/lib/webengine/webhittestresult.cpp | 17 ++--- src/lib/webengine/webhittestresult.h | 8 +-- src/lib/webengine/webpage.cpp | 27 -------- src/lib/webengine/webpage.h | 8 +-- src/lib/webengine/webscrollbarmanager.cpp | 5 -- src/lib/webengine/webview.cpp | 29 ++------ src/lib/webtab/searchtoolbar.cpp | 4 -- src/plugins/GreaseMonkey/gm_manager.cpp | 12 ---- .../kdeframeworksintegrationplugin.h | 4 -- .../kioschemehandler.cpp | 9 +-- src/plugins/PyFalkon/CMakeLists.txt | 18 ++--- src/plugins/PyFalkon/pyfalkon_global.h | 4 -- src/plugins/PyFalkon/typesystem_pyfalkon.xml | 4 -- .../StatusBarIcons/sbi_networkicon.cpp | 26 +------- src/plugins/StatusBarIcons/sbi_networkicon.h | 9 --- src/plugins/TabManager/tabmanagerdelegate.cpp | 4 -- src/plugins/TabManager/tabmanagerwidget.cpp | 18 ----- src/plugins/TabManager/tabmanagerwidget.h | 4 -- .../TabManager/tabmanagerwidgetcontroller.cpp | 8 --- .../TabManager/tldextractor/tldextractor.cpp | 7 -- src/plugins/VerticalTabs/tablistview.cpp | 4 -- 65 files changed, 73 insertions(+), 618 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 55f3f8821..d3598047c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -10,6 +10,10 @@ set(RELEASE_SERVICE_VERSION "${RELEASE_SERVICE_VERSION_MAJOR}.${RELEASE_SERVICE_ # Project name and version project(Falkon VERSION ${RELEASE_SERVICE_VERSION}) +set(KF_MAJOR_VERSION "6") +set(QT_MIN_VERSION "6.4.0") +set(KF_MIN_VERSION "5.240.0") + # Find ECM, with nice error handling in case of failure include(FeatureSummary) find_package(ECM 5.78.0 CONFIG) @@ -26,15 +30,6 @@ include(ECMSetupVersion) include(ECMAddAppIcon) include(ECMQtDeclareLoggingCategory) include(ECMPoQmTools) -if (QT_MAJOR_VERSION STREQUAL "6") - set(QT_MIN_VERSION "6.4.0") - set(KF_MIN_VERSION "5.240.0") - set(KF_MAJOR_VERSION "6") -else() - set(QT_MIN_VERSION "5.15.0") - set(KF_MIN_VERSION "5.78.0") - set(KF_MAJOR_VERSION "5") -endif() # Output dirs (like ECM 5.38 does) set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib") @@ -60,13 +55,8 @@ add_definitions(-DQT_NO_URL_CAST_FROM_STRING -DQT_USE_QSTRINGBUILDER -DQT_NO_CAS # Mandatory: Qt5/6 find_package(Qt${QT_MAJOR_VERSION} ${QT_MIN_VERSION} REQUIRED COMPONENTS Core Widgets Network Sql QuickWidgets PrintSupport WebChannel) -if (QT_MAJOR_VERSION STREQUAL "6") - find_package(Qt6WebEngineCore ${QT_MIN_VERSION} REQUIRED) - find_package(Qt6WebEngineWidgets ${QT_MIN_VERSION} REQUIRED) -else() - find_package(Qt5WebEngine ${QT_MIN_VERSION} REQUIRED) - find_package(Qt5WebEngineWidgets ${QT_MIN_VERSION} REQUIRED) -endif() +find_package(Qt6WebEngineCore ${QT_MIN_VERSION} REQUIRED) +find_package(Qt6WebEngineWidgets ${QT_MIN_VERSION} REQUIRED) if (BUILD_TESTING) find_package(Qt${QT_MAJOR_VERSION} ${QT_MIN_VERSION} REQUIRED COMPONENTS Test) endif() @@ -77,9 +67,6 @@ endif() if (UNIX AND NOT APPLE AND NOT NO_X11) add_definitions(-DQZ_WS_X11) find_package(XCB REQUIRED COMPONENTS XCB UTIL) - if (NOT (QT_MAJOR_VERSION STREQUAL "6")) - find_package(Qt${QT_MAJOR_VERSION} ${QT_MIN_VERSION} REQUIRED COMPONENTS X11Extras) - endif() endif() if (WIN32) add_definitions(-DW7API) @@ -108,14 +95,12 @@ if (WIN32) add_definitions(-D_WIN32_WINNT=${ver}) endif() -if (QT_MAJOR_VERSION STREQUAL "6") - find_package(Qt6Core5Compat) -endif() +find_package(Qt6Core5Compat) # Mandatory: OpenSSL find_package(OpenSSL REQUIRED) -# Mandatory: KF5/6 +# Mandatory: KF6 find_package(KF${KF_MAJOR_VERSION} REQUIRED COMPONENTS Archive) # KF5I18n: Mandatory with downloaded translations (only for ki18n_install) @@ -152,30 +137,17 @@ endif() # Optional: PySide2 option(BUILD_PYTHON_SUPPORT "Support for Python plugins" ON) if (BUILD_PYTHON_SUPPORT) - if (QT_MAJOR_VERSION STREQUAL "6") - # Optional: PySide6 - find_package(PySide6 "6.4.0") - find_package(Shiboken6 "6.4.0") - find_package(Shiboken6Tools "6.4.0") - find_package(Python3 COMPONENTS Development) - set_package_properties(PySide6 PROPERTIES DESCRIPTION "Python plugins" TYPE OPTIONAL) - set_package_properties(Shiboken6 PROPERTIES DESCRIPTION "Python plugins" TYPE OPTIONAL) - set_package_properties(Shiboken6Tools PROPERTIES DESCRIPTION "Python plugins" TYPE OPTIONAL) - set_package_properties(Python3 PROPERTIES DESCRIPTION "Python plugins" TYPE OPTIONAL) - if (PySide6_FOUND AND Shiboken6_FOUND AND Shiboken6Tools_FOUND AND Python3_FOUND) - set(ENABLE_PYTHON_PLUGINS TRUE) - endif() - else() - # Optional: PySide2 - find_package(PySide2 "2.0.0") - find_package(Shiboken2 "2.0.0") - find_package(Python3 COMPONENTS Development) - set_package_properties(PySide2 PROPERTIES DESCRIPTION "Python plugins" TYPE OPTIONAL) - set_package_properties(Shiboken2 PROPERTIES DESCRIPTION "Python plugins" TYPE OPTIONAL) - set_package_properties(Python3 PROPERTIES DESCRIPTION "Python plugins" TYPE OPTIONAL) - if (PySide2_FOUND AND Shiboken2_FOUND AND Python3_FOUND) - set(ENABLE_PYTHON_PLUGINS TRUE) - endif() + # Optional: PySide6 + find_package(PySide6 "6.4.0") + find_package(Shiboken6 "6.4.0") + find_package(Shiboken6Tools "6.4.0") + find_package(Python3 COMPONENTS Development) + set_package_properties(PySide6 PROPERTIES DESCRIPTION "Python plugins" TYPE OPTIONAL) + set_package_properties(Shiboken6 PROPERTIES DESCRIPTION "Python plugins" TYPE OPTIONAL) + set_package_properties(Shiboken6Tools PROPERTIES DESCRIPTION "Python plugins" TYPE OPTIONAL) + set_package_properties(Python3 PROPERTIES DESCRIPTION "Python plugins" TYPE OPTIONAL) + if (PySide6_FOUND AND Shiboken6_FOUND AND Shiboken6Tools_FOUND AND Python3_FOUND) + set(ENABLE_PYTHON_PLUGINS TRUE) endif() endif() diff --git a/src/lib/3rdparty/fancytabwidget.cpp b/src/lib/3rdparty/fancytabwidget.cpp index 384a64fdf..bda32b962 100644 --- a/src/lib/3rdparty/fancytabwidget.cpp +++ b/src/lib/3rdparty/fancytabwidget.cpp @@ -307,11 +307,7 @@ void FancyTabBar::paintEvent(QPaintEvent* event) } } -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) -void FancyTab::enterEvent(QEvent*) -#else void FancyTab::enterEvent(QEnterEvent*) -#endif { fadeIn(); } diff --git a/src/lib/3rdparty/fancytabwidget.h b/src/lib/3rdparty/fancytabwidget.h index eceff02c8..da6f397be 100644 --- a/src/lib/3rdparty/fancytabwidget.h +++ b/src/lib/3rdparty/fancytabwidget.h @@ -86,11 +86,7 @@ public: QString text; protected: -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - void enterEvent(QEvent *event) override; -#else void enterEvent(QEnterEvent *event) override; -#endif void leaveEvent(QEvent*) override; private: diff --git a/src/lib/3rdparty/qtsingleapplication/qtlocalpeer.cpp b/src/lib/3rdparty/qtsingleapplication/qtlocalpeer.cpp index 3160d6743..d94af8723 100644 --- a/src/lib/3rdparty/qtsingleapplication/qtlocalpeer.cpp +++ b/src/lib/3rdparty/qtsingleapplication/qtlocalpeer.cpp @@ -43,10 +43,7 @@ #include #include #include - -#if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)) #include -#endif #include "../config.h" #if defined(Q_OS_LINUX) && !defined(DISABLE_DBUS) @@ -114,11 +111,7 @@ QtLocalPeer::QtLocalPeer(QObject* parent, const QString &appId) #endif prefix = id.section(QLatin1Char('/'), -1); } -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - prefix.remove(QRegExp("[^a-zA-Z]")); -#else prefix = QRegExp("[^a-zA-Z]").removeIn(prefix); -#endif prefix.truncate(6); QByteArray idc = id.toUtf8(); diff --git a/src/lib/3rdparty/stylehelper.cpp b/src/lib/3rdparty/stylehelper.cpp index 9324af89e..c817c760a 100644 --- a/src/lib/3rdparty/stylehelper.cpp +++ b/src/lib/3rdparty/stylehelper.cpp @@ -160,11 +160,7 @@ void StyleHelper::verticalGradient(QPainter* painter, const QRect &spanRect, con clipRect.height(), keyColor.rgb()); QPixmap pixmap; -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - if (!QPixmapCache::find(key, pixmap)) { -#else if (!QPixmapCache::find(key, &pixmap)) { -#endif pixmap = QPixmap(clipRect.size()); QPainter p(&pixmap); QRect rect(0, 0, clipRect.width(), clipRect.height()); @@ -187,11 +183,7 @@ void StyleHelper::drawIconWithShadow(const QIcon &icon, const QRect &rect, QPixmap cache; QString pixmapName = QSL("icon %0 %1 %2").arg(icon.cacheKey()).arg(iconMode).arg(rect.height()); -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - if (!QPixmapCache::find(pixmapName, cache)) { -#else if (!QPixmapCache::find(pixmapName, &cache)) { -#endif QPixmap px = icon.pixmap(rect.size(), iconMode); px.setDevicePixelRatio(qApp->devicePixelRatio()); cache = QPixmap(px.size() + QSize(radius * 2, radius * 2)); diff --git a/src/lib/CMakeLists.txt b/src/lib/CMakeLists.txt index 964370d07..4ea872344 100644 --- a/src/lib/CMakeLists.txt +++ b/src/lib/CMakeLists.txt @@ -577,41 +577,23 @@ qt_add_resources(SRCS add_library(FalkonPrivate SHARED ${SRCS} ${LOGGING_SRCS}) -if (QT_MAJOR_VERSION STREQUAL "6") - get_property(QT_WEBENGINE_INCLUDE_DIRS TARGET Qt6::WebEngineCore PROPERTY INTERFACE_INCLUDE_DIRECTORIES) -else() - get_property(QT_WEBENGINE_INCLUDE_DIRS TARGET Qt::WebEngine PROPERTY INTERFACE_INCLUDE_DIRECTORIES) -endif() +get_property(QT_WEBENGINE_INCLUDE_DIRS TARGET Qt6::WebEngineCore PROPERTY INTERFACE_INCLUDE_DIRECTORIES) target_include_directories(FalkonPrivate SYSTEM PUBLIC ${QT_WEBENGINE_INCLUDE_DIRS}) -if (QT_MAJOR_VERSION STREQUAL "6") - target_link_libraries(FalkonPrivate - Qt6::Widgets - Qt6::WebEngineWidgets - Qt6::Network - Qt6::NetworkPrivate - Qt6::Sql - Qt6::PrintSupport - Qt6::QuickWidgets - Qt6::WebChannel - Qt6::Core5Compat - KF6::Archive - ${OPENSSL_CRYPTO_LIBRARY} - ) -else() - target_link_libraries(FalkonPrivate - Qt::Widgets - Qt::WebEngineWidgets - Qt::Network - Qt::Sql - Qt::PrintSupport - Qt::QuickWidgets - Qt::WebChannel - KF5::Archive - ${OPENSSL_CRYPTO_LIBRARY} - ) -endif() +target_link_libraries(FalkonPrivate + Qt6::Widgets + Qt6::WebEngineWidgets + Qt6::Network + Qt6::NetworkPrivate + Qt6::Sql + Qt6::PrintSupport + Qt6::QuickWidgets + Qt6::WebChannel + Qt6::Core5Compat + KF6::Archive + ${OPENSSL_CRYPTO_LIBRARY} +) if (HAVE_LIBINTL) target_include_directories(FalkonPrivate SYSTEM PUBLIC ${Intl_INCLUDE_DIRS}) @@ -621,9 +603,6 @@ endif() if (UNIX AND NOT APPLE) if (NOT NO_X11) target_link_libraries(FalkonPrivate XCB::XCB) - if (NOT (QT_MAJOR_VERSION STREQUAL "6")) - target_link_libraries(FalkonPrivate Qt::X11Extras) - endif() endif() set_target_properties(FalkonPrivate PROPERTIES VERSION ${PROJECT_VERSION} SOVERSION "3") diff --git a/src/lib/adblock/adblockmanager.cpp b/src/lib/adblock/adblockmanager.cpp index 6d36445a7..353e706bb 100644 --- a/src/lib/adblock/adblockmanager.cpp +++ b/src/lib/adblock/adblockmanager.cpp @@ -296,11 +296,7 @@ void AdBlockManager::load() } QTextStream textStream(&file); -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - textStream.setCodec("UTF-8"); -#else textStream.setEncoding(QStringConverter::Utf8); -#endif QString title = textStream.readLine(1024).remove(QLatin1String("Title: ")); QUrl url = QUrl(textStream.readLine(1024).remove(QLatin1String("Url: "))); diff --git a/src/lib/adblock/adblockrule.cpp b/src/lib/adblock/adblockrule.cpp index e36cedea7..80ae71bb8 100644 --- a/src/lib/adblock/adblockrule.cpp +++ b/src/lib/adblock/adblockrule.cpp @@ -53,16 +53,12 @@ #include #include -#if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)) +/* TODO Qt6 Replace with PUBLIC API */ #include #include -#endif static QString getTopLevelDomain(const QUrl &url) { -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - return url.topLevelDomain(); -#else // QUrl::topLevelDomain() was removed in Qt6. // The following is copied from the old "qTopLevelDomain" code in Qt6::Network. // It was removed in this commit: https://github.com/qt/qtbase/commit/50b30976837be0969efdccced68cfb584d99981a @@ -81,7 +77,6 @@ static QString getTopLevelDomain(const QUrl &url) //return qt_ACE_do(tld, ToAceOnly, AllowLeadingDot, {}); // TODO QT6 - QUrl::toAce() uses ForbidLeadingDot, while the old QUrl::topLevelDomain() used AllowLeadingDot. Does this matter? return QString(QUrl::toAce(tld)); -#endif } static QString toSecondLevelDomain(const QUrl &url) diff --git a/src/lib/adblock/adblocksubscription.cpp b/src/lib/adblock/adblocksubscription.cpp index 4ef128ea2..a2e21987c 100644 --- a/src/lib/adblock/adblocksubscription.cpp +++ b/src/lib/adblock/adblocksubscription.cpp @@ -103,11 +103,7 @@ void AdBlockSubscription::loadSubscription(const QStringList &disabledRules) } QTextStream textStream(&file); -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - textStream.setCodec("UTF-8"); -#else - textStream.setEncoding(QStringConverter::Utf8); -#endif + textStream.setEncoding(QStringConverter::Utf8); // Header is on 3rd line textStream.readLine(1024); textStream.readLine(1024); @@ -310,11 +306,7 @@ void AdBlockCustomList::loadSubscription(const QStringList &disabledRules) if (file.open(QFile::WriteOnly | QFile::Append)) { QTextStream stream(&file); -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - stream.setCodec("UTF-8"); -#else stream.setEncoding(QStringConverter::Utf8); -#endif if (!rules.contains(ddg1 + QL1S("\n"))) stream << ddg1 << Qt::endl; @@ -337,11 +329,7 @@ void AdBlockCustomList::saveSubscription() } QTextStream textStream(&file); -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - textStream.setCodec("UTF-8"); -#else textStream.setEncoding(QStringConverter::Utf8); -#endif textStream << "Title: " << title() << Qt::endl; textStream << "Url: " << url().toString() << Qt::endl; textStream << "[Adblock Plus 1.1.1]" << Qt::endl; diff --git a/src/lib/app/browserwindow.cpp b/src/lib/app/browserwindow.cpp index b4b5feec3..884e5a97d 100644 --- a/src/lib/app/browserwindow.cpp +++ b/src/lib/app/browserwindow.cpp @@ -72,9 +72,6 @@ #include #include #include -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) -#include -#endif #include #include #include @@ -82,9 +79,6 @@ #include #ifdef QZ_WS_X11 -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) -#include -#endif #include #include #endif @@ -405,11 +399,7 @@ void BrowserWindow::setupUi() m_statusBar->addButton(downloadsButton); m_navigationToolbar->addToolButton(downloadsButton); -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - QDesktopWidget* desktop = mApp->desktop(); -#else auto desktop = QGuiApplication::primaryScreen(); -#endif int windowWidth = desktop->availableGeometry().width() / 1.3; int windowHeight = desktop->availableGeometry().height() / 1.3; @@ -1573,14 +1563,10 @@ void BrowserWindow::closeTab() #ifdef QZ_WS_X11 static xcb_connection_t *getXcbConnection() { -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - return QX11Info::connection(); -#else const QNativeInterface::QX11Application *x11App = qApp->nativeInterface(); if (x11App == nullptr) return 0; return x11App->connection(); -#endif } int BrowserWindow::getCurrentVirtualDesktop() const diff --git a/src/lib/app/mainapplication.cpp b/src/lib/app/mainapplication.cpp index a769318cb..5d312f3f4 100644 --- a/src/lib/app/mainapplication.cpp +++ b/src/lib/app/mainapplication.cpp @@ -62,9 +62,6 @@ #include #include #include -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) -#include -#endif #include #include #include @@ -298,11 +295,7 @@ MainApplication::MainApplication(int &argc, char** argv) NetworkManager::registerSchemes(); registerAllowedSchemes(); -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - m_webProfile = isPrivate() ? new QWebEngineProfile() : QWebEngineProfile::defaultProfile(); -#else m_webProfile = isPrivate() ? new QWebEngineProfile() : new QWebEngineProfile(QSL("Default")); -#endif connect(m_webProfile, &QWebEngineProfile::downloadRequested, this, &MainApplication::downloadRequested); m_webProfile->setNotificationPresenter([&] (std::unique_ptr notification) { @@ -408,11 +401,9 @@ MainApplication::~MainApplication() delete m_cookieJar; m_cookieJar = nullptr; -#if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)) // On Qt 6, deleting the web profile is necessary in order to make sure cache, cookies, etc. are flushed to disk. delete m_webProfile; m_webProfile = nullptr; -#endif Settings::syncSettings(); } @@ -946,11 +937,7 @@ void MainApplication::runDeferredPostLaunchActions() checkOptimizeDatabase(); } -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) -void MainApplication::downloadRequested(QWebEngineDownloadItem *download) -#else void MainApplication::downloadRequested(QWebEngineDownloadRequest *download) -#endif { downloadManager()->download(download); } @@ -1016,11 +1003,7 @@ void MainApplication::loadSettings() webSettings->setFontSize(QWebEngineSettings::MinimumLogicalFontSize, settings.value(QSL("MinimumLogicalFontSize"), 5).toInt()); settings.endGroup(); -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - QWebEngineProfile* profile = QWebEngineProfile::defaultProfile(); -#else QWebEngineProfile* profile = m_webProfile; -#endif profile->setPersistentCookiesPolicy(QWebEngineProfile::AllowPersistentCookies); profile->setPersistentStoragePath(DataPaths::currentProfilePath()); @@ -1210,17 +1193,9 @@ void MainApplication::setUserStyleSheet(const QString &filePath) userCss += QzTools::readAllFileContents(filePath).remove(QLatin1Char('\n')); const QString name = QStringLiteral("_falkon_userstylesheet"); - -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - QWebEngineScript oldScript = m_webProfile->scripts()->findScript(name); - if (!oldScript.isNull()) { - m_webProfile->scripts()->remove(oldScript); - } -#else for (const QWebEngineScript &oldScript : m_webProfile->scripts()->find(name)) { m_webProfile->scripts()->remove(oldScript); } -#endif if (userCss.isEmpty()) return; diff --git a/src/lib/app/mainapplication.h b/src/lib/app/mainapplication.h index aea5c8270..4003ac65f 100644 --- a/src/lib/app/mainapplication.h +++ b/src/lib/app/mainapplication.h @@ -31,11 +31,7 @@ class QMenu; class QWebEngineProfile; class QWebEngineSettings; class QNetworkAccessManager; -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) -class QWebEngineDownloadItem; -#else class QWebEngineDownloadRequest; -#endif class History; class AutoFill; @@ -150,11 +146,7 @@ private Q_SLOTS: void onFocusChanged(); void runDeferredPostLaunchActions(); -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - void downloadRequested(QWebEngineDownloadItem *download); -#else void downloadRequested(QWebEngineDownloadRequest *download); -#endif private: enum PostLaunchAction { diff --git a/src/lib/autofill/autofill.cpp b/src/lib/autofill/autofill.cpp index 3f5bcc199..dae78dc1c 100644 --- a/src/lib/autofill/autofill.cpp +++ b/src/lib/autofill/autofill.cpp @@ -249,9 +249,6 @@ QByteArray AutoFill::exportPasswords() QByteArray output; QXmlStreamWriter stream(&output); -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - stream.setCodec("UTF-8"); -#endif stream.setAutoFormatting(true); stream.writeStartDocument(); diff --git a/src/lib/bookmarks/bookmarksexport/htmlexporter.cpp b/src/lib/bookmarks/bookmarksexport/htmlexporter.cpp index e0e78e994..38f4fb770 100644 --- a/src/lib/bookmarks/bookmarksexport/htmlexporter.cpp +++ b/src/lib/bookmarks/bookmarksexport/htmlexporter.cpp @@ -49,11 +49,7 @@ bool HtmlExporter::exportBookmarks(BookmarkItem* root) } QTextStream stream(&file); -#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) - stream.setCodec("UTF-8"); -#else - stream.setEncoding(QStringConverter::Utf8); -#endif + stream.setEncoding(QStringConverter::Utf8); stream << "" << Qt::endl; stream << "