Falkon/falkonOfficial
Falkon/falkonOfficial
1
Fork 0
mirror of https://invent.kde.org/network/falkon.git synced 2024-12-20 18:56:34 +01:00
Code Releases Activity

WebPage: Add Q_UNREACHABLE to createWindow(WebBrowserWindow)

Browse Source
This commit is contained in:
David Rosca 2015-10-04 19:51:39 +02:00
parent 6857270057
commit e161e45c41
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/lib/webengine/webpage.cpp
View File

@ -592,8 +592,11 @@ QWebEnginePage* WebPage::createWindow(QWebEnginePage::WebWindowType type)
switch (type) { switch (type) {
case QWebEnginePage::WebBrowserWindow: case QWebEnginePage::WebBrowserWindow:
// TODO: Investigate when this is called from html // WebBrowserWindow is only called after Shift+LeftClick on link, but we handle
qDebug() << "WebBrowserWindow"; // this case ourselves, so it should never be called.
qWarning() << "Asked to created WebBrowserWindow!";
Q_UNREACHABLE();
case QWebEnginePage::WebBrowserTab: { case QWebEnginePage::WebBrowserTab: {
int index = window->tabWidget()->addView(QUrl(), Qz::NT_CleanSelectedTab); int index = window->tabWidget()->addView(QUrl(), Qz::NT_CleanSelectedTab);
TabbedWebView* view = window->weView(index); TabbedWebView* view = window->weView(index);