From e49ea20f337e268d27f264b2fbaee983ef03d19c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Rios?= Date: Sun, 12 Mar 2017 16:57:19 +0000 Subject: [PATCH] Fixed new tab not opening on mouse mid button click (#2244) Whenever the user pressed the middle button the mouse press handler in WebPage issued an 'execJavaScript' which has its own event loop causing the mouse release handler to be called before the field 'm_clickedUrl' get the url in the first handler. Since this field is used to guard the logic in the second handler the new tab wasn't opening. Closes #2238 --- src/lib/webengine/webpage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/webengine/webpage.cpp b/src/lib/webengine/webpage.cpp index 3af63680a..7efe1ccab 100644 --- a/src/lib/webengine/webpage.cpp +++ b/src/lib/webengine/webpage.cpp @@ -141,7 +141,7 @@ QVariant WebPage::execJavaScript(const QString &scriptSource, quint32 worldId, i } }); - loop->exec(); + loop->exec(QEventLoop::ExcludeUserInputEvents); delete loop; return result;