Applied patches for Mac OS + little modification of QupZilla icon.

- Mac patches by @ryandesign
- icon modifications by Sergio Cipolla, thanks!
- closes #220
- closes #221
- closes #222

AUTHORS

@@ -34,4 +34,5 @@ Special thanks:
 
 Jonathan Hooverman    <jonathan.hooverman@gmail.com>  (english language correction)
 Peter Vacula          <pvacula1989@gmail.com>         (for a big support in the beginnigs)
+Sergio Cipolla        <secipolla@gmail.com>           (modifications to QupZilla icon)
 Radomir Orkac                                         (qupzilla.com domain)

bin/themes/chrome/main.css

@@ -121,6 +121,7 @@
     border-width:4;
     color:black;
     padding-left: 28px;
+    padding-top: -2px;
     qproperty-fixedheight: 27;
 }
 
@@ -199,6 +200,7 @@
     border-width:4;
     color:black;
     padding-left: 35px;
+    padding-top: -2px;
     qproperty-fixedheight: 27;
 }
 

bin/themes/linux/main.css

@@ -117,6 +117,7 @@
     border-width:4;
     color:black;
     padding-left: 22px;
+    padding-top: -2px;
     qproperty-fixedheight: 27;
 }
 
@@ -188,6 +189,7 @@
     border-width:4;
     color:black;
     padding-left: 30px;
+    padding-top: -2px;
     qproperty-fixedheight: 27;
 }
 

src/Info.plist

@@ -15,6 +15,7 @@
     <key>CFBundleIdentifier</key>
     <string>com.qupzilla.QupZilla</string>
     
+    <key>CFBundleDocumentTypes</key>
     <array>
       <dict>
         <key>CFBundleTypeExtensions</key>
@@ -43,8 +44,5 @@
     <string>QupZilla</string>
     <key>CFBundleDisplayName</key>
     <string>QupZilla</string>
-    
-    <key>NOTE</key>
-    <string>QupZilla Web Browser</string>
 </dict>
 </plist>

src/app/mainapplication.cpp

@@ -101,7 +101,7 @@ MainApplication::MainApplication(const QList<CommandLineOptions::ActionPair> &cm
 #endif
 
 #ifdef Q_WS_MAC
-    DATADIR.append("Resources/");
+    DATADIR.append("../Resources/");
 #endif
 
 #ifdef PORTABLE_BUILD
@@ -115,7 +115,7 @@ MainApplication::MainApplication(const QList<CommandLineOptions::ActionPair> &cm
     THEMESDIR = DATADIR + "themes/";
 
     setOverrideCursor(Qt::WaitCursor);
-    setWindowIcon(QupZilla::qupzillaIcon());
+    setWindowIcon(QIcon(":icons/exeicons/qupzilla-window.png"));
     bool noAddons = false;
     QUrl startUrl("");
     QStringList messages;

src/app/qupzilla.cpp

@@ -71,18 +71,6 @@ const QString QupZilla::WWWADDRESS = "http://www.qupzilla.com";
 const QString QupZilla::WIKIADDRESS = "https://github.com/nowrep/QupZilla/wiki";
 const QString QupZilla::WEBKITVERSION = qWebKitVersion();
 
-const QIcon QupZilla::qupzillaIcon()
-{
-    QIcon i;
-    i.addFile(":icons/exeicons/qupzilla16.png");
-    i.addFile(":icons/exeicons/qupzilla32.png");
-    i.addFile(":icons/exeicons/qupzilla48.png");
-    i.addFile(":icons/exeicons/qupzilla64.png");
-    i.addFile(":icons/exeicons/qupzilla128.png");
-    i.addFile(":icons/exeicons/qupzilla256.png");
-    return i;
-}
-
 QupZilla::QupZilla(Qz::BrowserWindow type, QUrl startUrl)
     : QMainWindow(0)
     , m_historyMenuChanged(true)

src/app/qupzilla.h

@@ -76,8 +76,6 @@ public:
     static const QString WIKIADDRESS;
     static const QString WEBKITVERSION;
 
-    static const QIcon qupzillaIcon();
-
     explicit QupZilla(Qz::BrowserWindow type, QUrl startUrl = QUrl());
     ~QupZilla();
 

src/data/icons.qrc

@@ -43,12 +43,6 @@
         <file>icons/other/bighistory.png</file>
         <file>icons/menu/dot.png</file>
         <file>icons/preferences/style-default.png</file>
-        <file>icons/exeicons/qupzilla16.png</file>
-        <file>icons/exeicons/qupzilla32.png</file>
-        <file>icons/exeicons/qupzilla48.png</file>
-        <file>icons/exeicons/qupzilla64.png</file>
-        <file>icons/exeicons/qupzilla128.png</file>
-        <file>icons/exeicons/qupzilla256.png</file>
         <file>icons/faenza/user-bookmarks.png</file>
         <file>icons/other/adblock-disabled.png</file>
         <file>icons/menu/search-icon.png</file>
@@ -68,5 +62,6 @@
         <file>icons/browsers/html.png</file>
         <file>icons/menu/translate.png</file>
         <file>icons/menu/duck.png</file>
+        <file>icons/exeicons/qupzilla-window.png</file>
     </qresource>
 </RCC>

src/navigation/navigationbar.cpp

@@ -95,6 +95,7 @@ NavigationBar::NavigationBar(QupZilla* mainClass, QWidget* parent)
     m_menuForward = new Menu(this);
     m_buttonNext->setMenu(m_menuForward);
 
+#ifndef Q_WS_MAC
     m_supMenu = new ToolButton(this);
     m_supMenu->setObjectName("navigation-button-supermenu");
     m_supMenu->setPopupMode(QToolButton::InstantPopup);
@@ -102,6 +103,7 @@ NavigationBar::NavigationBar(QupZilla* mainClass, QWidget* parent)
     m_supMenu->setAutoRaise(true);
 //    m_supMenu->setVisible(false);
     m_supMenu->setMenu(p_QupZilla->superMenu());
+#endif
 
     m_searchLine = new WebSearchBar(p_QupZilla);
 

src/plugins/webpluginfactory.cpp

@@ -21,9 +21,9 @@
 #include "pluginproxy.h"
 #include "webpage.h"
 
-WebPluginFactory::WebPluginFactory(QObject* parent)
-    : QWebPluginFactory(parent)
-    , m_page(0)
+WebPluginFactory::WebPluginFactory(WebPage* page)
+    : QWebPluginFactory(page)
+    , m_page(page)
 {
 }
 
@@ -56,31 +56,21 @@ QObject* WebPluginFactory::create(const QString &mimeType, const QUrl &url, cons
         return 0;
     }
 
-    WebPluginFactory* factory = const_cast<WebPluginFactory*>(this);
-    if (!factory) {
-        return 0;
-    }
+//    WebPluginFactory* factory = const_cast<WebPluginFactory*>(this);
+//    if (!factory) {
+//        return 0;
+//    }
 
-    WebPage* page = factory->parentPage();
-    if (!page) {
-        return 0;
-    }
+//    WebPage* page = factory->parentPage();
+//    if (!page) {
+//        return 0;
+//    }
 
 
-    ClickToFlash* ctf = new ClickToFlash(url, argumentNames, argumentValues, page);
+    ClickToFlash* ctf = new ClickToFlash(url, argumentNames, argumentValues, m_page);
     return ctf;
 }
 
-WebPage* WebPluginFactory::parentPage()
-{
-    if (m_page) {
-        return m_page;
-    }
-
-    WebPage* page = qobject_cast<WebPage*> (parent());
-    return page;
-}
-
 QList<QWebPluginFactory::Plugin> WebPluginFactory::plugins() const
 {
 //    QList<QWebPluginFactory::Plugin> plugins;

src/plugins/webpluginfactory.h

@@ -25,13 +25,11 @@ class WebPage;
 class WebPluginFactory : public QWebPluginFactory
 {
 public:
-    WebPluginFactory(QObject* parent);
+    WebPluginFactory(WebPage *page);
     virtual QObject* create(const QString &mimeType, const QUrl &url, const QStringList &argumentNames, const QStringList &argumentValues) const;
     QList<QWebPluginFactory::Plugin> plugins() const;
 
 private:
-    WebPage* parentPage();
-
     WebPage* m_page;
 
 };

src/src.pro

@@ -396,7 +396,7 @@ mac {
 
     bundle_target.files += ../bin/locale
     bundle_target.files += ../bin/themes
-    bundle_target.path = Resources
+    bundle_target.path = Contents/Resources
 
     QMAKE_BUNDLE_DATA += bundle_target
 }
@@ -433,22 +433,22 @@ mac {
     target3.files = ../linux/pixmaps/qupzilla.png
     target3.path = $$icon_folder
 
-    ico16.files = ../linux/hicolor/16x16/qupzilla.png
+    ico16.files = ../linux/hicolor/16x16/apps/qupzilla.png
     ico16.path = $$hicolor_folder/16x16/apps
 
-    ico32.files = ../linux/hicolor/32x32/qupzilla.png
+    ico32.files = ../linux/hicolor/32x32/apps/qupzilla.png
     ico32.path = $$hicolor_folder/32x32/apps
 
-    ico48.files = ../linux/hicolor/48x48/qupzilla.png
+    ico48.files = ../linux/hicolor/48x48/apps/qupzilla.png
     ico48.path = $$hicolor_folder/48x48/apps
 
-    ico64.files = ../linux/hicolor/64x64/qupzilla.png
+    ico64.files = ../linux/hicolor/64x64/apps/qupzilla.png
     ico64.path = $$hicolor_folder/64x64/apps
 
-    ico128.files = ../linux/hicolor/128x128/qupzilla.png
+    ico128.files = ../linux/hicolor/128x128/apps/qupzilla.png
     ico128.path = $$hicolor_folder/128x128/apps
 
-    ico256.files = ../linux/hicolor/256x256/qupzilla.png
+    ico256.files = ../linux/hicolor/256x256/apps/qupzilla.png
     ico256.path = $$hicolor_folder/256x256/apps
 
     INSTALLS += target target1 target2 target3

tests/link_tests.html

@@ -52,6 +52,8 @@ Original file used from kWebKitPart (https://projects.kde.org/projects/extragear
   <br/>
   <a href="javascript:window.open('http://www.gmail.com', '_blank', 'width=600,height=600,statusbar=no,toolbar=no')">Open Gmail (new window)</a>
   <br/>
+  <a href="javascript:window.open('http://www.openshot.org/videos/', '_blank', 'width=600,height=600,statusbar=no,toolbar=no')">ClickToFlash (new window)</a>
+  <br/>
   <a href="javascript:window.close()">Close window</a>
   <br/>
 <h2>Form Tests</h2>