Summary:
The qmake build did that, installing a directory called 'linux' into
/usr/share/themes seems to be a recipe for a possible collision and
most importantly it makes themes work.
Reviewers: #falkon, drosca
Differential Revision: https://phabricator.kde.org/D8116
Summary:
The current cmake files search for gnome keyring unconditionally, which
on source-based distros would lead to a hard dependency on the package.
Hence, it would be a good idea to introduce an option to deactivate this
if necessary.
Reviewers: #falkon, drosca
Reviewed By: #falkon, drosca
Subscribers: heikobecker, drosca
Differential Revision: https://phabricator.kde.org/D8038
Cleanup the includes:
QtGlobal is not needed - already pulled in by qzcommon.h
QString not needed, already pulled in by qzcommon.h
Move the qzcommon include before the ifdefs
This is a change that has been getting used when building QupZilla on FreeBSD for several years now and works fine.
Summary:
This streamlines the code across all platforms and outsources the path
building to QSP which implements the multi-platform logic.
This keeps AppData lookup paths where they were (with additional lookup
paths from QSP).
Config location changes on Windows (from local to roaming) and OS X
(from `Application Support` to `Preferences`).
Cache also changes location on Windows and OS X.
Temporary directory management is entirely outsourced to QTemporaryDir
which is kept in a scoped pointer so it gets cleaned up on exit.
Reviewers: drosca
Reviewed By: drosca
Differential Revision: https://phabricator.kde.org/D7767
Summary:
NB: this changes the standard config name of default constructed QSettings
(a quick grep seems to suggest there is no default constructed QSettings
though, so this should be fine).
Aligning the applicationName with the spelling in the installation paths
on case sensitive systems allows us to use QStandardPaths' built-in
handling for application-specific paths instead of having to manually
append /falkon to various paths.
Test Plan: still seems to be working on linux
Reviewers: drosca
Reviewed By: drosca
Differential Revision: https://phabricator.kde.org/D7721
I had to rename PNGs, but updated qmake buildsystem so it still works
(kind of, there are duplicate pngs installed, no big deal...)
Only tested on Linux, but tried to write the cmake code for OSX and
Windows specific things too.
Summary:
this is, for now, backwards compatible. in the long run a full move
to QSP instead of manually doing path lookup would be good though.
as that ideally means aligning capitalization between appname and on-disk
paths we'll avoid that for now.
fixes data lookup from XDG paths making the binary partially relocatable
and properly configurable via XDG paths (e.g. corporate branding or what
have you)
Test Plan: - theme path resolution now walks all XDG paths
Reviewers: drosca
Reviewed By: drosca
Differential Revision: https://phabricator.kde.org/D7600
