1
mirror of https://invent.kde.org/network/falkon.git synced 2024-11-15 03:22:11 +01:00
Commit Graph

400 Commits

Author SHA1 Message Date
David Rosca
8d06eee009
LocationCompleterView: Fix incorrect resize in some cases 2018-01-26 12:58:12 +01:00
David Rosca
5ee0623d32
LocationCompleter: Fix popup opening with suggestions after it was closed 2018-01-26 12:58:08 +01:00
David Rosca
b9294e02bb
LocationBar: Don't show favicon in site icon
Most of the sites are https nowadays, for which favicon is not
displayed, so there is no more a reason to show favicon in site
icon in locationbar.
Favicon is still displayed in tab icon.

Closes #918
2018-01-26 12:58:04 +01:00
David Rosca
948e623f9e
LocationBar: Show search icon as site icon when completion popup is open 2018-01-26 12:57:59 +01:00
David Rosca
4ad5900604
LocationCompleter: Call closePopup+clearCompletion also in indexActivated 2018-01-26 12:57:53 +01:00
David Rosca
3469d5b114
LocationCompleterView: Always resize on first adjustSize after show 2018-01-26 12:57:48 +01:00
David Rosca
3ec4d96f74
LocationCompleter: Properly close popup when showing search engines dialog 2018-01-26 12:57:44 +01:00
David Rosca
52076009e0
LocationComplterRefreshJob: Set HistoryRole for most visited completions
Closes #2570
2018-01-26 12:57:39 +01:00
David Rosca
99ceda4324
LocationCompleterView: Delay resizing popup to reduce flicker 2018-01-26 12:57:34 +01:00
David Rosca
09ee6007e9
LocationCompleter: Handle creating LoadRequest
Instead of just passing string that LocationBar should somehow
parse and decide what to do (which may not correspond to what was
indicated in completion entry), make the LocationCompleter create
it with all needed info and pass it to LocationBar to load.

This fixes issue where search completions may have been loaded
with different search engine when suggestion starts with search
engine shortcut (which would also get cut in the search).

This also removes the possibility to open new window from completer
with activating entry with Shift key.
2018-01-26 12:57:30 +01:00
David Rosca
8d45c910bf
LocationBar: Add LoadAction
It represents action to be taken after submitting text in LocationBar.
Use it from LocationCompleterDelegate instead of duplicating the logic.

This fixes showing incorrect indication when typing bookmark keyword
and when search suggestions begins with search engine shortcut.
2018-01-26 12:57:22 +01:00
David Rosca
4140aae6d2
LocationCompleterView: Add buttons with all search engines 2018-01-26 12:56:50 +01:00
David Rosca
fe8eb7f122
LocationCompleterView: No need to use QPointer for SearchEnginesDialog 2018-01-26 12:55:57 +01:00
David Rosca
b618323a5e
LocationCompleterView: Add button to open search engine settings
Closes #2568
2018-01-26 12:55:52 +01:00
David Rosca
d443a69d8f
LocationCompleterView: Fix Shift+Tab handling 2018-01-26 12:55:46 +01:00
David Rosca
11e2ff168e
LocationCompleterView: Change into QWidget 2018-01-26 12:55:29 +01:00
David Rosca
bb76281174
LocationCompleterDelegate: Don't make link color lighter 2018-01-26 12:54:52 +01:00
David Rosca
b0c2a09f94
LocationCompleterDelegate: Use smaller font for link text
Instead of using bigger font for title, use normal font size
for title and smaller font for link.
2018-01-26 12:54:47 +01:00
David Rosca
4b5bae697a NavigationBar: Show AdBlock icon in toolbar by default 2018-01-24 20:46:40 +01:00
David Rosca
41775c3a20 Replace some QupZilla leftovers with Falkon 2018-01-24 17:15:26 +01:00
David Rosca
f7cbab1562 LocationCompleter: Don't highligh search string in visit/search item 2018-01-16 12:52:04 +01:00
David Rosca
7ba18669a2 LocationCompleter: Update original text also without inline completions enabled
Closes #2550
2018-01-16 12:51:39 +01:00
David Rosca
a8dcf176cf Fix merge issues 2018-01-11 20:51:34 +01:00
David Rosca
4bf85ee3cb WebPage: Register QWebChannel on isolated ApplicationWorld
This way scripts on pages don't have access to it.
Exception is qupzilla: scheme as internal pages requires the bridge.

GreaseMonkey userscripts now runs on ApplicationWorld too. This fixes
userscript that depend on script world being isolated from main page world.
Tested with 4ChanX + OneeChan.
2018-01-11 19:55:01 +01:00
David Rosca
80eb072bb1 NavigationBarToolButton: Prevent down state flickering when showing popup 2018-01-11 19:49:17 +01:00
David Rosca
e21e147bbb NavigationBarConfigDialog: Fix restore to defaults action 2018-01-11 19:48:59 +01:00
David Rosca
23f84abc3b NavigationBar: Correctly filter invalid layout ids 2018-01-11 19:48:50 +01:00
David Rosca
1f9599aac7 Add DownloadsButton to navigation toolbar
It is visible only when there are items in download manager and shows
number of active downloads in badge text.
2018-01-11 19:48:43 +01:00
David Rosca
0e41fd0785 AbstractButtonInterface: Add support for hiding tool button 2018-01-11 19:48:06 +01:00
David Rosca
238a06874d AbstractButtonInterface: Allow delayed hide of popup 2018-01-11 19:48:01 +01:00
David Rosca
df632c7ced NavigationBar: Only reload layout when settings changes 2018-01-11 19:46:51 +01:00
David Rosca
e33174100e NavigationBar: Bring back exit fullscreen button
This time it is configurable and hidden by default.
2018-01-11 19:46:44 +01:00
David Rosca
7adda247dc NavigationBar: Make sure search bar doesn't have null size in splitter 2018-01-11 19:45:23 +01:00
David Rosca
670e06cbc6 Change back "Sidebars" -> "Sidebar" 2018-01-11 19:44:59 +01:00
David Rosca
5dfe6d862c NavigationBar: Clear current webview for all tool buttons
Fixes another crash similar to #2537
2018-01-11 19:44:35 +01:00
David Rosca
4dd67cfce6 LocationCompleter: Set BrowserWindow as transient parent 2018-01-11 19:44:30 +01:00
David Rosca
6806fa5405 AbstractButtonInterface: Use WebView property instead of WebPage
WebView of a tab will not change while WebPage may.

This also fixes crash when WebPage of WebView is changed. It can happen
eg. when opening new tab from page with target=_blank.

Closes #2537
2018-01-11 19:42:38 +01:00
David Rosca
ba2ea9cb09 AbstractButtonInterface: Rename badgeLabelText -> badgeText 2018-01-11 19:36:54 +01:00
David Rosca
15a2afb4b6 NavigationBar: Add support for badge text in tool buttons 2018-01-11 19:36:49 +01:00
David Rosca
74f45f6028 NavigationBarToolButton: Add support for inactive state 2018-01-11 19:33:13 +01:00
David Rosca
4a4d5b72ad Add NavigationBarConfigDialog
Allows to change layout of navigation bar and hide/show search bar.
2018-01-11 19:32:54 +01:00
David Rosca
546e777c7c NavigationContainer: Also add bottom margin with tabs on top 2018-01-11 19:31:33 +01:00
David Rosca
8cbaa19dd1 Use correct margins from style in NavigationBar and BookmarksToolbar 2018-01-11 19:31:17 +01:00
David Rosca
c5b59d1011 ToolButton: Disable showing button menu on right click by default 2018-01-11 19:30:05 +01:00
David Rosca
23279f6e10 GreaseMonkey: Move icon from statusbar to navigationbar as tool button 2018-01-11 19:29:35 +01:00
David Rosca
6824ea17f2 NavigationBar: Add support for adding additional tool buttons 2018-01-11 19:28:32 +01:00
David Rosca
0b8a693bca NavigationBar: Add Tools button
It now contains toolbars and sidebars menus and configure
action that doesn't work yet.
2018-01-11 19:25:54 +01:00
David Rosca
65d1493f0a Fix closing tabs - regression from last commits
Closes #2534
2018-01-11 19:25:48 +01:00
David Rosca
d380d54ef8 NavigationBar: Add support for loading layout from config
There is no ui to configure it for now.
2018-01-11 19:25:41 +01:00
David Rosca
2e7a77a6b4 NavigationBar: Remove exit fullscreen button 2018-01-11 19:24:58 +01:00
David Rosca
139a8dc8f1 LocationCompleter: Only allow to delete bookmarks and history items 2018-01-11 19:20:16 +01:00
David Rosca
89aa7259f9 LocationCompleter: Only update original text when first item is selected
Fixes issue where search/visit item would be incorrectly updated after
deleting item from completions.
2018-01-11 19:19:28 +01:00
David Rosca
f3b7be2b5e LocationBar: Fix correctly loading "localhost" instead of launching search
Closes #2028
2018-01-01 17:02:12 +01:00
David Rosca
b6dd2a829d LocationCompleter: Fix showing old suggestions for one char search string
When typing a search string and then deleting it up to last character,
old suggestions for 2-character search string would be displayed.
2018-01-01 16:56:03 +01:00
David Rosca
eb92250003 LocationCompleter: Enable suggestions from 2 and more characters 2018-01-01 16:55:57 +01:00
Laurent Cimon
635cb1085c Add an option to disable search suggestions from the address bar.
Differential Revision: https://phabricator.kde.org/D9539
2017-12-31 16:44:02 +01:00
David Rosca
925e3496d9 LocationCompleterModel: Don't set tab position to view/search item 2017-12-30 18:06:26 +01:00
David Rosca
c1c168aae9 Create every QSqlQuery with correct database for current thread
Queries are now always executed on correct database instance.
Databases are also stored in thread local storage instead of in hash
table with mutex.

Closes #2498
2017-12-18 13:06:42 +01:00
David Rosca
ff6de32d3d LocationCompleterModel: Order domain completion result by date
Fixes showing irrelevant (first match) domain completions

Closes #2471
2017-11-08 15:59:24 +01:00
David Rosca
033f701784 LocationCompleter: Fix possibility to be opened at wrong position/time 2017-11-01 17:38:24 +01:00
David Rosca
845d59e5d7 LocationCompleter: Ignore canceled refresh jobs
Skip updating completion model with invalid data from canceled jobs,
which could result in attempt to resize the completer popup to invalid
size (0 height) and when the popup is resized again to valid size kwin
may actually fail to show it with compositing enabled.

Should help with #2480
2017-11-01 17:38:11 +01:00
David Rosca
40d42f1230 LoadRequest: Replace isEmpty with isValid
Also test for QUrl being valid, not just not empty
2017-10-09 12:06:25 +02:00
David Rosca
e267b47fb1 LocationCompleter: Fix searching for text that is not valid QUrl
Closes #2457
2017-10-09 11:57:17 +02:00
Razi Alavizadeh
e5b89fd5f5 LocationCompleterDelegate: Don't align RTL titles to right after new delegate.
- The old delegate was using separate lines for title and link
  after 5f9fe54086 it uses just one line.
2017-08-29 12:26:31 +04:30
David Rosca
d00e769749 Initial rename to Falkon 2017-08-25 17:32:32 +02:00
David Rosca
04df4cbdf8 LocationCompleter: Fix search engine shortcuts 2017-08-25 16:11:58 +02:00
David Rosca
d3153355d7 LocationCompleterView: Make sure focusProxy() is not null
See #2421
2017-08-21 11:16:10 +02:00
David Rosca
0203cab204 LocationCompleterDelegate: Only draw "search with" on selected/hovered items 2017-08-12 15:46:54 +02:00
David Rosca
82700cae38 LocationCompleterDelegate: Draw icons with correct mode 2017-08-12 15:25:36 +02:00
David Rosca
0524bbc1a6 LocationCompleter: Don't allow to delete search/visit completion item 2017-08-12 15:10:39 +02:00
David Rosca
20010eb3c4 LocationCompleter: Fix incorrectly showing search action after domain completion 2017-08-12 15:09:29 +02:00
David Rosca
5f9fe54086 LocationCompleterDelegate: Draw title and address in one line
Also show twice as much available completions.
2017-08-12 15:02:00 +02:00
David Rosca
d7ff9546d6 Fix build 2017-08-11 15:46:19 +02:00
David Rosca
7e6600bb48 Change wording "Search on" -> "Search with"
Also don't show "URL" in interface, "address" is enough.
2017-08-11 15:29:15 +02:00
David Rosca
2867f9fed5 LocationCompleter: Show search suggestions 2017-08-11 15:29:09 +02:00
David Rosca
c3bead5ed7 LocationCompleterView: Completely remove the hovered index tracking logic 2017-08-11 13:01:41 +02:00
David Rosca
6bceef43e2 LocationCompleter: Don't change selected index with mouseover
Also render proper item state (selected / under mouse) in delegate.
2017-08-11 12:56:55 +02:00
David Rosca
9e8614447e LocationCompleterDelegate: Better logic for limiting URL length 2017-08-11 12:42:07 +02:00
David Rosca
029aa6823b LocationCompleterView: Don't propagate Esc key press 2017-08-11 12:32:23 +02:00
David Rosca
16b3a74aa1 LocationCompleter: Add persistent first item that shows used search engine
Or in case searching from location bar is disabled or entered text
is valid URL, it indicates that this URL will be loaded.
2017-08-11 12:32:18 +02:00
David Rosca
d0f6a3f909 WebSearchBar: Search when clicking on search suggestion
Closes #2281
2017-07-19 13:27:30 +02:00
David Rosca
05492a89e6 LocationCompleterView: Fix selecting items with mouse
See #2365
2017-07-19 12:39:36 +02:00
David Rosca
9f266ac1e0 LocationCompleterView: Only use special window flags on xcb platform 2017-07-19 12:26:26 +02:00
Elvis Angelaccio
2a2c49ca47 Ensure transient parent window for LocationCompleterView
This makes sure that the completer listview is properly positioned on
wayland. Tested with Qt 5.9 RC.

Closes #2344.
2017-06-08 09:47:39 +02:00
David Rosca
281919fc4d LocationCompleterView: Use custom window type only on X11
Closes #2287
2017-04-02 16:35:38 +02:00
David Rosca
b95a8be600 LocationCompleterView: Fix window type on Wayland
Closes #2236
2017-02-26 20:27:37 +01:00
David Rosca
3045cf28b2 Merge branch 'v2.1' 2017-02-20 17:20:39 +01:00
David Rosca
e86f96878e Fix clicking on go icon when location completer popup is visible
Closes #2225
2017-02-20 17:20:00 +01:00
David Rosca
71b06197ef LocationCompleterView: Use better window type
It is no longer modal, so it doesn't break shortcuts.

Closes #2213
2017-02-13 21:01:21 +01:00
David Rosca
85f8cf881e Fix drawing text with correct color in item delegates on Windows 2017-02-07 15:47:41 +01:00
David Rosca
c44b8b9309 LocationBarPopup: Use QFrame::Raised 2017-01-27 13:42:05 +01:00
David Rosca
9b3fc5f404 Update ignored schemes for saving history and icons 2016-12-31 14:53:06 +01:00
David Rosca
e21636c661 Add more HighDPI ready icons in data/icons/menu 2016-12-29 15:07:34 +01:00
David Rosca
82e9d0c0ee LocationBar: Complete domain when going back to original text 2016-12-29 12:11:40 +01:00
David Rosca
23af6c3af7 Fix drawing correct text color in custom item views 2016-12-26 19:41:06 +01:00
David Rosca
1a0ec338de LocationBar: Replace all contents when dropping text 2016-12-24 11:41:50 +01:00
David Rosca
c7fa3101db LocationCompleterRefreshJob: Use IconProvider to load icons
IconProvider can now be used from different threads
2016-12-20 12:19:51 +01:00
David Rosca
c2d38dfb7d SqlDatabase::query now modifies the passed SqlQuery 2016-12-20 11:22:31 +01:00
David Rosca
38bf9d2b4a Use QWebEngineView::icon() instead of custom icon downloading 2016-10-24 21:19:27 +02:00
blaze
bc47a9aba5 Show Bookmark Toolbar when Location Bar gets focus
Optional behaviour providing quick access to bookmarks without
wasting the vertical space
2016-08-23 08:57:11 +02:00