Falkon/falkonOfficial
Falkon/falkonOfficial
1
Fork 0
mirror of https://invent.kde.org/network/falkon.git synced 2024-12-24 04:36:34 +01:00
Code Releases Activity

Update expectations for popupwindows test

Browse Source
This commit is contained in:
David Rosca 2015-09-29 11:21:17 +02:00
parent fcaa2b4559
commit 2582ee3562
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/webengine/webpage.cpp
View File

@ -964,7 +964,9 @@ QWebEnginePage* WebPage::createWindow(QWebEnginePage::WebWindowType type)
BrowserWindow *window = tView ? tView->browserWindow() : mApp->getWindow(); BrowserWindow *window = tView ? tView->browserWindow() : mApp->getWindow();
switch (type) { switch (type) {
case QWebEnginePage::WebBrowserWindow: // TODO case QWebEnginePage::WebBrowserWindow:
// TODO: Investigate when this is called from html
qDebug() << "WebBrowserWindow";
case QWebEnginePage::WebBrowserTab: { case QWebEnginePage::WebBrowserTab: {
int index = window->tabWidget()->addView(QUrl(), Qz::NT_CleanSelectedTab); int index = window->tabWidget()->addView(QUrl(), Qz::NT_CleanSelectedTab);
TabbedWebView* view = window->weView(index); TabbedWebView* view = window->weView(index);

4
tests/popupwindows.html
View File

@ -18,11 +18,11 @@
<a href="javascript:window.open('popup.html', '_blank')">Popup 2</a> <a href="javascript:window.open('popup.html', '_blank')">Popup 2</a>
- with second argument _blank - with second argument _blank
</p> </p>
<b>Will be opened in popup window</b>
<p> <p>
<a href="javascript:window.open('popup.html', '_blank', 'left=100,right=200')">Popup 3</a> <a href="javascript:window.open('popup.html', '_blank', 'left=100,right=200')">Popup 3</a>
- with left and righ (should be opened as popup, but how to detect it?) - with left and righ
</p> </p>
<b>Will be opened in popup window</b>
<p> <p>
<a href="javascript:window.open('popup.html', '_blank', 'width=150,height=150')">Popup 4</a> <a href="javascript:window.open('popup.html', '_blank', 'width=150,height=150')">Popup 4</a>
- with width and height - with width and height