Falkon/falkonOfficial
Falkon/falkonOfficial
1
Fork 0
mirror of https://invent.kde.org/network/falkon.git synced 2024-12-20 18:56:34 +01:00
Code Releases Activity

remove CloseButton::hideEvent()

Browse Source 
That causes crashes when entering/leaving fullscreen mode when the tabbar has non-closable tabs.
deleteLater() in the hideEvent left a dangling pointer in the corresponding QTabBarPrivate::Tab.
The next re-layout of the tabs caused the crash when querying the size of the deleted closeButton:

[...]
This commit is contained in:
Franz Fellner 2012-10-24 18:24:39 +02:00
parent e8745590ac
commit d08ec28d70
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/lib/webview/tabbar.cpp
View File

@ -647,15 +647,6 @@ void CloseButton::leaveEvent(QEvent* event)
QAbstractButton::leaveEvent(event); QAbstractButton::leaveEvent(event);
} }
void CloseButton::hideEvent(QHideEvent* event)
{
QAbstractButton::hideEvent(event);
if (!isVisible()) {
deleteLater();
}
}
void CloseButton::paintEvent(QPaintEvent*) void CloseButton::paintEvent(QPaintEvent*)
{ {
QPainter p(this); QPainter p(this);

1
src/lib/webview/tabbar.h
View File

@ -128,7 +128,6 @@ public:
void enterEvent(QEvent* event); void enterEvent(QEvent* event);
void leaveEvent(QEvent* event); void leaveEvent(QEvent* event);
void hideEvent(QHideEvent* event);
void paintEvent(QPaintEvent* event); void paintEvent(QPaintEvent* event);
}; };