That causes crashes when entering/leaving fullscreen mode when the tabbar has non-closable tabs.
deleteLater() in the hideEvent left a dangling pointer in the corresponding QTabBarPrivate::Tab.
The next re-layout of the tabs caused the crash when querying the size of the deleted closeButton:
[...]
* move helper-functions in navigationbar.cpp into NavigationBar [private]
* remove (unused) 2nd arg in WebSearchBar/NavigationBar and use mainClass as parent.
* remove NavigationBar-destructor (not needed)
* remove WebSearchBar::m_menu and create a QMenu-instance directly in WebSearchBar::contextMenuEvent()
Also adjusted mac siteicon-[secure]-bg.png to not have opaque pixels, which would cut content (e.g. Top progress bar).
Filled bar is now drawn independent of textRect.
Also set m_progressVisible only to false (in hideProgress), if m_loadProgress==100. If the user clicks
a link during the 700ms-timeout, the bar shows for a short time and hideProgress sets m_progressVisible to false, though
the page still is loading, which hides the bar in mid-run.
This also fixes the weird behaviour of the progressbar on session-restore.
The switch is needed due to palette problems on some color schemes (e.g. inverted look for popupmenus or tooltips), which could lead to unreadable text.
* QupZilla is not firefox or chrome: QZ has speeddial by default, the latter ones only by extensions.
So adding an url to the unsorted bookmarks by default when clicking the star is a no-go, as the user probably only wants to add a speed dial.
The star is the only possibility to add speed dials.
* Having a save and a remove-button possibly confuses the user (at least confused me ;))
Only take one button and change the text according to the state.
* Disable the name-edit and folder-combo in the case the url is already bookmarked.
Chosing another folder and press save will move the bookmark to another folder.
Moving bookmarks IMHO is the job of the "organize bookmarks" tool (renaming them, too)
***
In a future (post-1.3.5) I would like to see the bookmark-button an the folder-choser merged like it is done in Opera.
(Opera HAS speed dial by default)
But I am open for suggestions :)
