Falkon/falkonOfficial
Falkon/falkonOfficial
1
Fork 0
mirror of https://invent.kde.org/network/falkon.git synced 2024-12-21 03:06:34 +01:00
Code Releases Activity
4,577 Commits 28 Branches 57 Tags 60 MiB
87527762f8
Commit Graph

3505 Commits

Author SHA1 Message Date
Razi Alavizadeh
bad3a76a2e TabManager: Don't repeat detaching tab code. 2017-10-03 17:02:30 +03:30
Razi Alavizadeh
33846b9523 TabManager: Use italic font and "disabled" style for non-loaded saved tab item. 2017-10-03 17:02:29 +03:30
Razi Alavizadeh
b9a9c24060 TabManager: Cleanup and fix. 2017-10-03 17:02:28 +03:30
Razi Alavizadeh
9cb5f106ef TabManager: item based update. 2017-10-03 17:02:27 +03:30
Razi Alavizadeh
06094cfc1c TabManager: Scroll to the current tab item. 2017-10-03 17:02:27 +03:30
Razi Alavizadeh
f17eb82cf9 TabManager: Add tab context-menu to treewidget context-menu. 2017-10-03 17:02:26 +03:30
Razi Alavizadeh
04b288b395 Fix restoring non-loaded tabs when moving them. 2017-10-03 17:02:25 +03:30
Razi Alavizadeh
f041d87534 Move tab context-menu methods to TabContextMenu. 2017-10-03 17:02:24 +03:30
Heiko Becker
a683fbde0b Install themes to falkon subdir 
Summary:
The qmake build did that, installing a directory called 'linux' into
/usr/share/themes seems to be a recipe for a possible collision and
most importantly it makes themes work.

Reviewers: #falkon, drosca

Differential Revision: https://phabricator.kde.org/D8116
 2017-10-03 11:30:16 +02:00
Razi Alavizadeh
ebd8dd051e Windows: Fix compile issues after build system changed to cmake. 
Differential Revision: https://phabricator.kde.org/D8079
 2017-10-03 11:03:35 +03:30
David Rosca
2732aadda6 Fix building GnomeKeyring and KWallet password backend plugins 
Also remove KDE/GNOME integration options and instead always build the plugins
when necessary dependencies are found.
 2017-09-26 15:19:55 +02:00
David Rosca
02f7c68ec2 Move themes to root source directory + remove bin directory 2017-09-26 10:49:39 +02:00
Luigi Toscano
3c67be06b9 Fix UI strings with plural forms 
Otherwise those strings can not be extracted.
 2017-09-26 01:37:46 +02:00
Jacob Tey
11d73bd26a Fix icon name in SBI images icon + add object name to AdBlockIcon 2017-09-25 19:35:44 +02:00
Ken Moore
c75324f379 Update processinfo.h 
Cleanup the includes:
QtGlobal is not needed - already pulled in by qzcommon.h
QString not needed, already pulled in by qzcommon.h
Move the qzcommon include before the ifdefs

This is a change that has been getting used when building QupZilla on FreeBSD for several years now and works fine.
 2017-09-25 19:27:16 +02:00
David Rosca
626e8c5f8a Change library SOVERSION to 2 2017-09-25 18:37:47 +02:00
David Rosca
484a7cc882 Fix themes and locale install paths on Linux 2017-09-25 18:36:22 +02:00
David Rosca
df25f49cfb Remove more unused files 2017-09-25 14:18:33 +02:00
David Rosca
3b09f115e7 Remove QMake build files 2017-09-25 13:08:06 +02:00
David Rosca
c77ec4005e Don't include plugins translations as resource 
Fixes CMake build, but plugin translations are not working now.
 2017-09-25 13:04:54 +02:00
l10n daemon script
524237b202 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2017-09-19 05:03:47 +02:00
Harald Sitter
b60b2e36e9 port DataPaths to QStandardPaths backing 
Summary:
This streamlines the code across all platforms and outsources the path
building to QSP which implements the multi-platform logic.

This keeps AppData lookup paths where they were (with additional lookup
paths from QSP).
Config location changes on Windows (from local to roaming) and OS X
(from `Application Support` to `Preferences`).
Cache also changes location on Windows and OS X.

Temporary directory management is entirely outsourced to QTemporaryDir
which is kept in a scoped pointer so it gets cleaned up on exit.

Reviewers: drosca

Reviewed By: drosca

Differential Revision: https://phabricator.kde.org/D7767
 2017-09-18 12:57:23 +02:00
l10n daemon script
395cb5d2f5 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2017-09-18 05:00:58 +02:00
Harald Sitter
2b3b95ae36 change qapp applicationName to lower case 
Summary:
NB: this changes the standard config name of default constructed QSettings
  (a quick grep seems to suggest there is no default constructed QSettings
   though, so this should be fine).

Aligning the applicationName with the spelling in the installation paths
on case sensitive systems allows us to use QStandardPaths' built-in
handling for application-specific paths instead of having to manually
append /falkon to various paths.

Test Plan: still seems to be working on linux

Reviewers: drosca

Reviewed By: drosca

Differential Revision: https://phabricator.kde.org/D7721
 2017-09-11 14:13:47 +02:00
David Faure
eecaf2e9d6 Fix compilation with -DQT_NO_CAST_TO_ASCII 2017-09-11 10:05:28 +02:00
David Faure
76457af130 CMake buildsystem for the autotest 2017-09-10 15:17:07 +02:00
David Faure
6e7a14a9c2 CMake buildsystem for plugins 2017-09-10 15:01:58 +02:00
David Faure
31d0e1f6b3 CMake buildsystem for src/main as well. 
I had to rename PNGs, but updated qmake buildsystem so it still works
(kind of, there are duplicate pngs installed, no big deal...)

Only tested on Linux, but tried to write the cmake code for OSX and
Windows specific things too.
 2017-09-10 13:35:21 +02:00
David Faure
d69e5458f9 First steps towards a cmake buildsystem, currently only builds src/lib. 
USE_DATADIR no longer exists, QStandardPaths::standardLocations is used
unless NO_SYSTEM_DATAPATH is set.
 2017-09-09 20:27:44 +02:00
l10n daemon script
ca377a0d65 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2017-09-06 08:25:21 +02:00
l10n daemon script
d42b1ecf52 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2017-09-05 04:29:09 +02:00
l10n daemon script
691723e4f6 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2017-09-03 04:44:27 +02:00
l10n daemon script
3dc4685561 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2017-09-01 04:37:46 +02:00
l10n daemon script
765d27cde5 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2017-08-30 08:02:14 +02:00
Harald Sitter
58e4b9a3a7 extend data paths with standard paths from QStandardPaths 
Summary:
this is, for now, backwards compatible. in the long run a full move
to QSP instead of manually doing path lookup would be good though.
as that ideally means aligning capitalization between appname and on-disk
paths we'll avoid that for now.

fixes data lookup from XDG paths making the binary partially relocatable
and properly configurable via XDG paths (e.g. corporate branding or what
have you)

Test Plan: - theme path resolution now walks all XDG paths

Reviewers: drosca

Reviewed By: drosca

Differential Revision: https://phabricator.kde.org/D7600
 2017-08-29 14:38:46 +02:00
Razi Alavizadeh
e5b89fd5f5 LocationCompleterDelegate: Don't align RTL titles to right after new delegate. 
- The old delegate was using separate lines for title and link
  after 5f9fe54086 it uses just one line.
 2017-08-29 12:26:31 +04:30
l10n daemon script
b6dabb55aa SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2017-08-27 04:43:13 +02:00
l10n daemon script
d718a61042 SVN_SILENT made messages (.desktop file) - always resolve ours 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 2017-08-26 04:46:29 +02:00
David Rosca
efff69b7b2 Continue with Falkon renaming 2017-08-25 17:55:52 +02:00
David Rosca
d00e769749 Initial rename to Falkon 2017-08-25 17:32:32 +02:00
David Rosca
04df4cbdf8 LocationCompleter: Fix search engine shortcuts 2017-08-25 16:11:58 +02:00
David Rosca
1387baade0 SearchToolBar: Guard against running search callback after toolbar was deleted 2017-08-25 16:11:40 +02:00
srazi
a78b595569 Hide sidebar when a web element goes to full screen. 
- Closes #2423
 2017-08-23 14:02:26 +04:30
srazi
e0e21362cc Remove MPL notice in last commit. 2017-08-22 17:14:45 +04:30
srazi
2aa25fe0b1 Windows: At first try to show native default app settings UI (>=Vista). 2017-08-22 14:19:22 +02:00
srazi
21b2685375 Windows: Remove support to set QupZilla as default FTP handler. 
- Closes #2417
 2017-08-21 21:45:32 +04:30
David Rosca
d3153355d7 LocationCompleterView: Make sure focusProxy() is not null 
See #2421
 2017-08-21 11:16:10 +02:00
David Rosca
08274f5bbe Fix build warning 2017-08-19 19:11:45 +02:00
David Rosca
5812721e48 BrowserWindow: Fix failing to enter fullscreen sometimes 2017-08-19 18:52:26 +02:00
David Rosca
f3367e7611 AdBlockRule: Add support for ping, media and other options 
Also fix object-subrequest matching, it should block requests
from plugins despite its name.
 2017-08-12 17:31:11 +02:00
David Rosca
c2c49c6b13 AdBlock: Add support for rules with empty filter (match all) 2017-08-12 16:27:02 +02:00
David Rosca
67c6834a5f ComboTabBar: Disable focusing scroll buttons 2017-08-12 15:56:26 +02:00
David Rosca
0203cab204 LocationCompleterDelegate: Only draw "search with" on selected/hovered items 2017-08-12 15:46:54 +02:00
David Rosca
82700cae38 LocationCompleterDelegate: Draw icons with correct mode 2017-08-12 15:25:36 +02:00
David Rosca
0524bbc1a6 LocationCompleter: Don't allow to delete search/visit completion item 2017-08-12 15:10:39 +02:00
David Rosca
20010eb3c4 LocationCompleter: Fix incorrectly showing search action after domain completion 2017-08-12 15:09:29 +02:00
David Rosca
5f9fe54086 LocationCompleterDelegate: Draw title and address in one line 
Also show twice as much available completions.
 2017-08-12 15:02:00 +02:00
David Rosca
d7ff9546d6 Fix build 2017-08-11 15:46:19 +02:00
David Rosca
def0c8e4f4 Update empty.ts 2017-08-11 15:35:46 +02:00
David Rosca
7e6600bb48 Change wording "Search on" -> "Search with" 
Also don't show "URL" in interface, "address" is enough.
 2017-08-11 15:29:15 +02:00
David Rosca
2867f9fed5 LocationCompleter: Show search suggestions 2017-08-11 15:29:09 +02:00
David Rosca
c3bead5ed7 LocationCompleterView: Completely remove the hovered index tracking logic 2017-08-11 13:01:41 +02:00
David Rosca
6bceef43e2 LocationCompleter: Don't change selected index with mouseover 
Also render proper item state (selected / under mouse) in delegate.
 2017-08-11 12:56:55 +02:00
David Rosca
9e8614447e LocationCompleterDelegate: Better logic for limiting URL length 2017-08-11 12:42:07 +02:00
David Rosca
029aa6823b LocationCompleterView: Don't propagate Esc key press 2017-08-11 12:32:23 +02:00
David Rosca
16b3a74aa1 LocationCompleter: Add persistent first item that shows used search engine 
Or in case searching from location bar is disabled or entered text
is valid URL, it indicates that this URL will be loaded.
 2017-08-11 12:32:18 +02:00
David Faure
3c60b8417a Add missing RUNPATH so that qupzilla finds its shared lib 
when installed into a custom prefix, on Linux.
 2017-07-26 20:20:24 +02:00
David Faure
2382f2c955 Fix compilation with KDE in custom prefix 
The .pri file for KWallet brings in the correct include path for
that framework, while KF5/KWallet/KWallet only works with a /usr/include
base dir.
 2017-07-26 20:12:52 +02:00
David Rosca
f82cab9f19 Pull translations from Transifex 2017-07-24 12:05:22 +02:00
David Rosca
b05986bac3 Bookmarks: Warn when trying to open multiple bookmarks in tabs 
Closes #2340
 2017-07-19 14:09:49 +02:00
David Rosca
6f08f94e0f Workaround wrong focus when opening new tab from createWindow() 2017-07-19 13:57:37 +02:00
David Rosca
cbba636f61 Require C++14 2017-07-19 13:27:46 +02:00
David Rosca
d0f6a3f909 WebSearchBar: Search when clicking on search suggestion 
Closes #2281
 2017-07-19 13:27:30 +02:00
David Rosca
aefc3eba38 Disable QWebEngineSettings::FocusOnNavigationEnabled 
Keeping this enabled will focus views loaded in background tabs.

Closes #2352
 2017-07-19 13:06:25 +02:00
David Rosca
05492a89e6 LocationCompleterView: Fix selecting items with mouse 
See #2365
 2017-07-19 12:39:36 +02:00
David Rosca
9f266ac1e0 LocationCompleterView: Only use special window flags on xcb platform 2017-07-19 12:26:26 +02:00
David Rosca
54a6f65bee AdBlock: Fix saving subscriptions 
QSaveFile doesn't support QFile::Truncate mode
 2017-07-01 18:50:25 +02:00
David Rosca
9b933c1fb7 SessionManager: Show only session name in message box when deleting session 2017-06-08 15:00:03 +02:00
David Rosca
26eb3753c0 SessionManager: Make it possible to restore backups again 2017-06-08 14:56:52 +02:00
David Rosca
93d4d66054 SessionManager: Add Session Manager dialog instead of menu structure 
See #2331
 2017-06-08 14:13:15 +02:00
David Rosca
bc65a0a038 Add RemoveItemFocusDelegate and use it in SearchEnginesDialog 2017-06-08 13:08:38 +02:00
David Rosca
ea966925dc SearchEnginesDialog: Remove left padding for items in QTreeView 2017-06-08 13:00:13 +02:00
David Rosca
f62665b9d9 SuperMenu: Move help actions to Help submenu 
Also move Preferences action above About action
 2017-06-08 11:13:22 +02:00
David Rosca
c9a52e59c3 Use QSaveFile also in other places 2017-06-08 10:14:19 +02:00
David Rosca
1a818e5b6c SessionManager: Use QSaveFile for writing session to file 
See #2331
 2017-06-08 10:04:45 +02:00
Elvis Angelaccio
2a2c49ca47 Ensure transient parent window for LocationCompleterView 
This makes sure that the completer listview is properly positioned on
wayland. Tested with Qt 5.9 RC.

Closes #2344.
 2017-06-08 09:47:39 +02:00
ravas
8dd870bc53 corrected BREW_OPENSSL path #1850 2017-06-07 10:43:11 +02:00
David Rosca
0d2b8b6b81 Change linux desktop file name to org.qupzilla.QupZilla 
Closes #2308
 2017-06-06 17:56:49 +02:00
David Rosca
874b9f993c Fix required Qt version from main 2017-06-06 17:55:40 +02:00
David Rosca
567881f130 Fix warnings when building with GCC 7 2017-06-06 17:51:06 +02:00
David Rosca
f0b8ac2daa Use QWebEngineHttpRequest with Qt 5.9 2017-06-06 17:40:47 +02:00
David Rosca
fcc3cf1809 Don't show multiple autofill notifications to save/update password 
Close the old autofill notification before adding new one.
 2017-05-29 19:28:31 +02:00
David Rosca
49eb9a862e Workaround Ctrl+F keypress being eaten by QtWebEngine 5.9 2017-05-29 17:21:56 +02:00
David Rosca
16f9b2fde9 Rework the zoom bug workaround 
Qt 5.9 is affected too

Closes #2289
 2017-05-29 17:11:48 +02:00
David Rosca
3ec6ffa5c9 WebPage: Remove no longer used m_adjustingScheduled 2017-05-29 17:05:28 +02:00
David Rosca
f9778eeaad Make sure the QWebChannel object is initiated in SpeedDial/Restore pages 
Make it more robust, this also fixes issue with Qt 5.9

Closes #2329
 2017-05-29 16:46:25 +02:00
David Rosca
74c65c2272 Password observer: Also use 'login' input name as username 2017-05-29 16:15:09 +02:00
David Rosca
57172459d8 Fix comparing tagName in form observer 
Listen also to subtree mutations

Closes #2321
 2017-05-29 16:08:41 +02:00
David Rosca
bd9a33d6f9 Fix crash when opening target __blank links 
Regression from 92b49be0c2

Closes #2335
 2017-05-19 09:02:38 +02:00
Anthony Fieroni
92b49be0c2 Don't leak web page 
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
 2017-05-12 20:50:24 +02:00
Anthony Fieroni
db33b8d860 Workaround Qt5.8 zoom factor bug 
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
 2017-05-12 20:50:24 +02:00
David Rosca
54949f94f3 AesInterface: Don't use deprecated RAND_pseudo_bytes 2017-05-03 21:17:09 +02:00
David Rosca
0c4f20ff2d GreaseMonkey: Use better metadata parser 
Use QTextStream instead of parsing with regexps
 2017-05-01 11:05:08 +02:00
Jose Rios
efc4725e91 Fixed compilation for Openssl 1.1.0 
Most of libcrypto and libssl internal structures were made
opaque in this version not allowing to instatiate them in
the stack.

More info:
    * https://www.openssl.org/news/openssl-1.1.0-notes.html
    * https://github.com/openssl/openssl/issues/962#issuecomment-208792020
 2017-05-01 11:03:40 +02:00
David Rosca
355fc7e4a7 GreaseMonkey: Bump plugin version 2017-04-19 15:54:23 +02:00
David Rosca
a2e02a8922 GreaseMonkey: Use QtWebEngine's handling of include/exclude/match rules 2017-04-19 15:53:27 +02:00
David Rosca
166fe13747 GreaseMonkey: Make sure to download all require scripts when userscript changes 2017-04-19 15:41:21 +02:00
David Rosca
13402b2983 GreaseMonkey: Save require scripts with original filename 2017-04-19 13:31:35 +02:00
David Rosca
84477aa2dc GreaseMonkey: Don't store absolute path to require scripts 2017-04-19 13:25:46 +02:00
srazi
f57d6d0682 TabManager: Fix add tab button when grouping type is not window 2017-04-10 00:30:04 +04:30
David Rosca
eb0cf5065d WebView: Exit fullscreen on hide 
Closes #2294
 2017-04-09 10:33:57 +02:00
David Rosca
8e16efc1bf Fix crash when restoring history of internal pages with QtWebEngine 5.8 
Closes #2302
 2017-04-08 16:44:41 +02:00
srazi
0148b7aaff RestoreManager: Don't append WindowData with empty tabsState to restore data 2017-04-08 13:36:46 +04:30
David Rosca
1d8b2345ac Merge pull request #2297 from srazi/improve_tabmanager 
Improve TabManager
 2017-04-07 20:22:44 +02:00
David Rosca
3492999abe Don't return empty QByteArray when there are no tabs in session 2017-04-07 12:38:54 +02:00
David Rosca
cb4012c5c9 Don't save qupzilla:restore tabs in sessions 2017-04-07 12:36:42 +02:00
srazi
8a85fb3c0f TabManager: Bump version to 0.7.0 2017-04-07 13:31:20 +04:30
srazi
47e2c8c1f0 TabManager: show add tab button on window item under mouse. 2017-04-07 13:24:39 +04:30
srazi
457d32ae82 TabManager: Update close button icon 2017-04-07 13:24:38 +04:30
srazi
e40be295ab TabManager: Fix showing close button on show 2017-04-07 13:24:37 +04:30
srazi
ae29ef0030 TabManager: Rename TabFilterDelegate to TabManagerDelegate 2017-04-07 13:24:36 +04:30
srazi
3a7e843677 TabManager: show close button on tab item under mouse. 2017-04-07 13:24:36 +04:30
srazi
56c737d836 TabManager: Use single click to switch between tabs 2017-04-07 13:24:35 +04:30
srazi
755ec16598 Session manager (#2293) 2017-04-07 10:02:27 +02:00
srazi
2654081912 Fix 2178 (#2292) 
* CheckBoxDialog: Rewritten to inherit from QMessageBox

-  QMessageBox supports showing checkbox for Qt >= 5.2

* Add option to disable warning message when closing tabs from tabbar context menu.

- Closes #2178
 2017-04-05 10:27:03 +02:00
David Rosca
f961958989 Add another key shortcut for reload action 
Closes #2290
 2017-04-03 15:34:44 +02:00
David Rosca
281919fc4d LocationCompleterView: Use custom window type only on X11 
Closes #2287
 2017-04-02 16:35:38 +02:00
srazi
ade7b9c690 Refactor some codes related to sessions. (#2280) 2017-03-26 11:27:04 +02:00
Marti Martz
ac903a9c10 Unix: Allow git hooks to work for development on all related nixes including Mac (#2264) 2017-03-21 20:02:05 +01:00
srazi
345d03105f macOS: Fix global menu with multiple windows. 
- Closes #2261
 2017-03-20 11:37:33 +03:30
srazi
9af542aa03 macOS: Disable auto window tabbing (#2261) 2017-03-20 04:28:55 +03:30
David Rosca
9683f0f295 StatusBarMessage: Don't show for inactive windows 2017-03-18 17:22:21 +01:00
David Rosca
076deb7cdd Set PulseAudio property overrides to QupZilla app name and icon 
Closes #2262
 2017-03-18 17:19:57 +01:00
David Rosca
44cd68e3d9 Merge branch 'v2.1' 2017-03-18 16:11:34 +01:00
David Rosca
b61b4aca67 WebView: Don't change m_progress when loading finished 
QtWebEngine may emit loadProgress signal even after loadFinished
was already emitted.

Closes #2222
 2017-03-18 16:00:57 +01:00
srazi
1d0d555ed1 macOS: Fix paths of qtwebengine_dictionaries (#2261) 2017-03-18 02:39:25 +03:30
David Rosca
26340c8284 Merge branch 'v2.1' 2017-03-15 19:27:30 +01:00
David Rosca
fc37057bee Version 2.1.2 2017-03-15 19:26:50 +01:00
David Rosca
f20d421113 Merge branch 'v2.1' 2017-03-15 13:29:24 +01:00
David Rosca
900e5d593c Pull translations from Transifex 2017-03-15 13:27:29 +01:00
David Rosca
486b8f4c7d Workaround QWebEnginePage not scrolling to anchors when opened in background tab 
Closes #2242
 2017-03-15 13:11:27 +01:00
David Rosca
3434052690 Merge branch 'v2.1' 2017-03-15 11:00:14 +01:00
David Rosca
8940609a00 StatusBarIcons: Set object names for icons 
Closes #2251
 2017-03-15 10:59:51 +01:00
David Rosca
bfef9e2c03 Merge branch 'v2.1' 2017-03-15 10:53:44 +01:00
David Rosca
9211a8eceb Disable native scrollbars by default 
See #2246
 2017-03-15 10:49:27 +01:00
David Rosca
d18be6f8e4 ProfileManager: Fix warning when creating new profile 2017-03-15 10:48:00 +01:00
David Rosca
a4c3e49e3e AdBlock: Fix warning when creating new profile 2017-03-15 10:35:14 +01:00
José Rios
85832642db Fixed new tab not opening on mouse mid button click (#2244) 
Whenever the user pressed the middle button the mouse press handler
in WebPage issued an 'execJavaScript' which has its own event loop
causing the mouse release handler to be called before the field
'm_clickedUrl' get the url in the first handler. Since this field
is used to guard the logic in the second handler the new tab wasn't
opening.

Closes #2238
 2017-03-13 09:05:36 +01:00
srazi
3c8907284d macOS: Fix unused-private-field warning 2017-03-13 00:23:01 +03:30
José Rios
e49ea20f33 Fixed new tab not opening on mouse mid button click (#2244) 
Whenever the user pressed the middle button the mouse press handler
in WebPage issued an 'execJavaScript' which has its own event loop
causing the mouse release handler to be called before the field
'm_clickedUrl' get the url in the first handler. Since this field
is used to guard the logic in the second handler the new tab wasn't
opening.

Closes #2238
 2017-03-12 17:57:19 +01:00